Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 663570 - dev-python/lz4-* has automagic dep on app-arch/lz4
Summary: dev-python/lz4-* has automagic dep on app-arch/lz4
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Matthew Thode ( prometheanfire )
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-14 11:21 UTC by Hector Martin
Modified: 2019-03-11 22:26 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Hector Martin 2018-08-14 11:21:43 UTC
With app-arch/lz4 installed, emerge dev-python/lz4 yields:

# ldd /usr/lib/python2.7/site-packages/lz4.so | grep liblz4
        liblz4.so.1 => /usr/lib64/liblz4.so.1 (0x00007fdce8411000)

setup.py looks for a system lz4 and uses it instead of the bundled lib if available:

# Check to see if we have a lz4 library installed on the system and
# use it if so. If not, we'll use the bundled library. If lz4 is
# installed it will have a pkg-config file, so we'll use pkg-config to
# check for existence of the library.
try:
    pkg_config_exe = os.environ.get('PKG_CONFIG', None) or 'pkg-config'
    cmd = '{0} --exists liblz4'.format(pkg_config_exe).split()
    liblz4_found = subprocess.call(cmd) == 0
except OSError: 
    # pkg-config not present
    liblz4_found = False

dev-python/lz4 should probably just RDEPEND on app-arch/lz4 so that it always uses the system library. Alternatively, something like USE=+system-lz4 and a patch to force select which lz4 lib to use would be more flexible, but I'm not sure if there's much merit to supporting use of the bundled lib.
Comment 1 Mike Gilbert gentoo-dev 2018-08-14 13:23:11 UTC
> dev-python/lz4 should probably just RDEPEND on app-arch/lz4 so that it always uses the system library.

It is also needed at build time, so app-arch/lz4 should be in both DEPEND and RDEPEND.
Comment 2 Larry the Git Cow gentoo-dev 2019-03-11 22:26:40 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0dc8b7dbdeecc1dac7165dca6e6b46777f863b38

commit 0dc8b7dbdeecc1dac7165dca6e6b46777f863b38
Author:     Zamarin Arthur <arthurzam@gmail.com>
AuthorDate: 2019-03-10 06:02:24 +0000
Commit:     Patrice Clement <monsieurp@gentoo.org>
CommitDate: 2019-03-11 22:26:30 +0000

    dev-python/lz4: version 2.1.6 bump.
    
    Closes: https://bugs.gentoo.org/663570
    Signed-off-by: Zamarin Arthur <arthurzam@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/11324
    Signed-off-by: Patrice Clement <monsieurp@gentoo.org>

 dev-python/lz4/Manifest         |  1 +
 dev-python/lz4/lz4-2.1.6.ebuild | 23 +++++++++++++++++++++++
 2 files changed, 24 insertions(+)