Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 663170 - profiles/base/make.defaults invalid syntax in COLLISION_IGNORE
Summary: profiles/base/make.defaults invalid syntax in COLLISION_IGNORE
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Profiles (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-08 14:55 UTC by Ulrich Müller
Modified: 2018-08-09 08:40 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2018-08-08 14:55:43 UTC
By PMS section 5.2.4, https://projects.gentoo.org/pms/7/pms.html#x1-470005.2.4, "backslashes, except for line continuations, are not allowed" in make.defaults.

However, profiles/base/make.defaults assigns:
COLLISION_IGNORE="/lib/modules/* *.py[co] *\$py.class */dropin.cache"

According to mgorny this could be removed:

<mgorny> hmm, to be honest i think we could remove this by now
<ulm> I don't see any such file on my system
<ulm> what was it used for?
<mgorny> jython
<mgorny> but i think we can remove the whole thing as it was meant for python.eclass -> python-r1 transition
<mgorny> i.e. reowning the files
<ulm> will you just do it, or should I file a bug?
<mgorny> with protect-owned being the default and python.eclass being long gone...
<mgorny> hmm, please file a bug to python@
<mgorny> let's have a trace for why it happened
<mgorny> feel free to paste what i wrote above
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-08-08 14:57:27 UTC
So, anyone opposed?
Comment 2 Larry the Git Cow gentoo-dev 2018-08-09 08:40:12 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a75834757ba6574c49ade0c1c8edf00f56e05f07

commit a75834757ba6574c49ade0c1c8edf00f56e05f07
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2018-08-09 07:44:38 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2018-08-09 08:40:01 +0000

    profiles/base: Remove COLLISION_IGNORE for Python compiled mods
    
    Remove the obsolete COLLISION_IGNORE entries for compiled Python
    modules.  Those entries were historically added to ease the migration
    from python.eclass to python-r1 which involved taking ownership of
    compiled module files.  Nowadays they are rather irrelevant given that
    python.eclass is gone for a while, and protect-owned is the default.
    
    Also, the Jython variant happens to have invalid syntax.
    
    Closes: https://bugs.gentoo.org/663170

 profiles/base/make.defaults | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)