why should it be removed? It breaks the build on all other arches but amd64 and x86: 119:52.09 libsecurity_sandbox_common.a.desc 121:17.62 libjs_src.a.desc 121:22.77 /var/tmp/portage/www-client/firefox-60.1.0/work/firefox-60.0b8/security/sandbox/linux/reporter/SandboxReporter.cpp:30:2: error: #error "unrecognized architecture" 121:22.77 #error "unrecognized architecture" 121:22.77 ^~~~~ 121:27.70 libsecurity_sandbox_linux_broker.a.desc 121:30.20 /var/tmp/portage/www-client/firefox-60.1.0/work/firefox-60.0b8/security/sandbox/linux/reporter/SandboxReporter.cpp: In function 'void mozilla::SubmitToTelemetry(const mozilla::SandboxReport&)': 121:30.20 /var/tmp/portage/www-client/firefox-60.1.0/work/firefox-60.0b8/security/sandbox/linux/reporter/SandboxReporter.cpp:220:16: error: 'SANDBOX_ARCH_NAME' was not declared in this scope 121:30.21 key.Append(SANDBOX_ARCH_NAME "/"); 121:30.21 ^~~~~~~~~~~~~~~~~ 121:30.28 /var/tmp/portage/www-client/firefox-60.1.0/work/firefox-60.0b8/security/sandbox/linux/reporter/SandboxReporter.cpp:220:16: note: suggested alternative: 'SANDBOX_LOG_LEN' 121:30.28 key.Append(SANDBOX_ARCH_NAME "/"); 121:30.29 ^~~~~~~~~~~~~~~~~ 121:30.29 SANDBOX_LOG_LEN 121:31.42 gmake[4]: *** [/var/tmp/portage/www-client/firefox-60.1.0/work/firefox-60.0b8/config/rules.mk:1049: SandboxReporter.o] Error 1 looking into SandboxReporter.cpp makes me think this is not an accident: // Distinguish architectures for the telemetry key. #if defined(__i386__) #define SANDBOX_ARCH_NAME "x86" #elif defined(__x86_64__) #define SANDBOX_ARCH_NAME "amd64" #else #error "unrecognized architecture" #endif it is managed via configure: https://searchfox.org/mozilla-central/rev/f5fb323246bf22a3a3b4185882a1c5d8a2c02996/old-configure.in#3251
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=62269ba0c6a992f6bc4b2fec63e929882b8c4e3c commit 62269ba0c6a992f6bc4b2fec63e929882b8c4e3c Author: stefson <herrtimson@yahoo.de> AuthorDate: 2018-09-23 18:26:50 +0000 Commit: Thomas Deutschmann <whissi@gentoo.org> CommitDate: 2018-09-23 18:28:26 +0000 mozconfig-v6.60: remove obsolete sandbox detection Closes: https://github.com/gentoo/gentoo/pull/9954 Closes: https://bugs.gentoo.org/663040 Signed-off-by: Thomas Deutschmann <whissi@gentoo.org> eclass/mozconfig-v6.60.eclass | 3 --- 1 file changed, 3 deletions(-)
