Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 662934 - media-gfx/exiv2-0.26_p20180319 does not compile with clang (Patch)
Summary: media-gfx/exiv2-0.26_p20180319 does not compile with clang (Patch)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Graphics Project
URL: http://dev.exiv2.org/issues/1362
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2018-08-06 12:15 UTC by David Carlos Manuelda
Modified: 2018-08-07 07:06 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Fix Clang compilation (fix-clang-build.patch,641 bytes, patch)
2018-08-06 12:15 UTC, David Carlos Manuelda
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Carlos Manuelda 2018-08-06 12:15:14 UTC
Created attachment 542534 [details, diff]
Fix Clang compilation

This version was using -std=gnu++98 for both CXX and CFLAGS, but CLang does not admit it in C mode as it is a c++ flag only, thus it fails compilation.

This was reported upstream and checked it is fixed on their github.

I attach a patch that solves this issue or recommend another more recent bump.
Comment 1 Andreas Sturmlechner gentoo-dev 2018-08-07 00:09:01 UTC
Thanks for your report. Next time, please attach the full original upstream commit including header.
Comment 2 David Carlos Manuelda 2018-08-07 00:10:14 UTC
(In reply to Andreas Sturmlechner from comment #1)
> Thanks for your report. Next time, please attach the full original upstream
> commit including header.

Well, this patch is the one I made for fixing gentoo's snapshot, I don't know when this has been fixed in upstream, just realize it was fixed, thanks for the hint.
Comment 3 Andreas Sturmlechner gentoo-dev 2018-08-07 00:12:17 UTC
Sorry, I wrongly assumed you had taken it from upstream.
Comment 4 Larry the Git Cow gentoo-dev 2018-08-07 07:06:02 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=62dd0d84ce139e725fb8890b85fc1cfbff2e0c4e

commit 62dd0d84ce139e725fb8890b85fc1cfbff2e0c4e
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2018-08-07 00:08:53 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-08-07 07:05:39 +0000

    media-gfx/exiv2: Fix build with clang
    
    Reported-by: David Carlos Manuelda <StormByte@gmail.com>
    Closes: https://bugs.gentoo.org/662934
    Package-Manager: Portage-2.3.44, Repoman-2.3.10

 media-gfx/exiv2/exiv2-0.26_p20180319.ebuild        |  3 +-
 .../files/exiv2-0.26_p20180319-clang-fix.patch     | 47 ++++++++++++++++++++++
 2 files changed, 49 insertions(+), 1 deletion(-)