Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 662718 - flag-o-matic.eclass - strip-flags should not filter out -fuse-ld=xxxx
Summary: flag-o-matic.eclass - strip-flags should not filter out -fuse-ld=xxxx
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Toolchain Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-03 14:21 UTC by David Carlos Manuelda
Modified: 2018-08-24 22:50 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch for allowing -fuse-ld=* flag (0001-Allow-flag-for-chosing-linker-in-filter-flags.patch,679 bytes, patch)
2018-08-13 21:50 UTC, David Carlos Manuelda
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Carlos Manuelda 2018-08-03 14:21:09 UTC
There are many ebuilds using strip-flags to filter potentially dangerous flags, which is OK, but it also filters -fuse-ld=xxxx flag, which is not correct (or it should not) since that flag does not change compilation but linking, therefore should be respected (unless for example, forcing to bfd linker is wanted, like I've seen in other ebuilds)
Comment 1 Sergei Trofimovich (RETIRED) gentoo-dev 2018-08-13 21:30:34 UTC
Yeah, I think allowing -fuse-ld= is reasonable.
Comment 2 Sergei Trofimovich (RETIRED) gentoo-dev 2018-08-13 21:32:46 UTC
Would you like to give it a try yourself? Should be a matter adding a template to https://gitweb.gentoo.org/repo/gentoo.git/tree/eclass/flag-o-matic.eclass#n36
Comment 3 David Carlos Manuelda 2018-08-13 21:50:46 UTC
Created attachment 543328 [details, diff]
Patch for allowing -fuse-ld=* flag

Thanks for the opportunity :)
Comment 4 Larry the Git Cow gentoo-dev 2018-08-24 22:40:30 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=17e0688ccc36f3d0d018814555a28c8dcf878ccc

commit 17e0688ccc36f3d0d018814555a28c8dcf878ccc
Author:     David C. Manuelda <StormByte@gmail.com>
AuthorDate: 2018-08-13 21:46:41 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2018-08-24 22:40:23 +0000

    flag-o-matic.eclass: allow -fuse-ld=* in filter flags
    
    Closes: https://bugs.gentoo.org/662718

 eclass/flag-o-matic.eclass | 3 +++
 1 file changed, 3 insertions(+)
Comment 5 Sergei Trofimovich (RETIRED) gentoo-dev 2018-08-24 22:50:49 UTC
I tweaked the patch slightly. Thank you!