Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 662662 - =media-video/vlc-3.0.3-r1[bidi]: error: implicit declaration of function ‘fribidi_get_par_embedding_levels’
Summary: =media-video/vlc-3.0.3-r1[bidi]: error: implicit declaration of function ‘fri...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-02 17:12 UTC by Greg Turner
Modified: 2018-08-11 16:44 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
vlc-3.0.3-fribidi-accept-deprecated.patch (fribidi_ok_gimme_deprecated.patch,446 bytes, patch)
2018-08-02 17:12 UTC, Greg Turner
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Turner 2018-08-02 17:12:29 UTC
Created attachment 542164 [details, diff]
vlc-3.0.3-fribidi-accept-deprecated.patch

This looks new; presumably a fribidi update is the cause.  Have not checked vlc upstream but presumably if they're requesting this type of failure they'll know what to do with this once they stumble across it, if they haven't solved it already (iow I'm too lazy to go try to interface with those guys right now for something this trivial).

Compile failure this fixes looks like:

../doltlibtool  --tag=CC   --mode=compile x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I..  -DMODULE_STRING=\"$(p="text_renderer/freetype/libfreetype_plugin_la-text_layout.lo"; p="${p##*/}"; p="${p#lib}"; p="${p%_plugin*}"; p=$(echo "$p"|sed 's/-/_/g'); p="${p%.lo}"; echo "$p")\" -D__PLUGIN__  -I./access -I./codec -I/usr/include/freetype2 -I/usr/include/harfbuzz -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -DHAVE_FONTCONFIG -I/usr/include/fribidi -DHAVE_FRIBIDI -I/usr/include/harfbuzz -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -DHAVE_HARFBUZZ -I../include -I../include  -I/usr/include/samba-4.0  --param l1-cache-size=16 --param l1-cache-line-size=64 --param l2-cache-size=2048 -O2 -pipe -g -march=core2 -mtune=bdver2  -Wall -Wextra -Wsign-compare -Wundef -Wpointer-arith -Wvolatile-register-var -Wformat -Wformat-security -Wbad-function-cast -Wwrite-strings -Wmissing-prototypes -Werror-implicit-function-declaration -Winit-self -Wlogical-op -Wshadow=local -fvisibility=hidden -c -o text_renderer/freetype/libfreetype_plugin_la-text_layout.lo `test -f 'text_renderer/freetype/text_layout.c' || echo './'`text_renderer/freetype/text_layout.c
text_renderer/freetype/text_layout.c: In function ‘AnalyzeParagraph’:
text_renderer/freetype/text_layout.c:363:5: error: implicit declaration of function ‘fribidi_get_par_embedding_levels’; did you mean ‘fribidi_get_par_embedding_levels_ex’? [-Werror=implicit-function-declaration]
     fribidi_get_par_embedding_levels( p_paragraph->p_types,
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     fribidi_get_par_embedding_levels_ex
Comment 1 Greg Turner 2018-08-02 18:04:02 UTC
ok, fine.. :) 

here's upstream's real solution, which makes my workaround guilt-free to use :)

https://github.com/videolan/vlc/commit/26e2d3906658c30f2f88f4b1bc9630ec43bf5525#diff-3dcb6aafc9717398aaf5a2dc6cef31ad
Comment 2 Larry the Git Cow gentoo-dev 2018-08-11 16:44:22 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=da6e5a8bc6d2a4598852471e692fefb94b71180a

commit da6e5a8bc6d2a4598852471e692fefb94b71180a
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2018-08-11 13:51:45 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-08-11 16:43:53 +0000

    media-video/vlc: Fix build with >=dev-libs/fribidi-1
    
    Thanks-to: Greg Turner <gmturner007@ameritech.net>
    Closes: https://bugs.gentoo.org/662662
    Package-Manager: Portage-2.3.45, Repoman-2.3.10

 media-video/vlc/files/vlc-3.0.3-fribidi-1.patch | 80 +++++++++++++++++++++++++
 media-video/vlc/vlc-3.0.3-r1.ebuild             |  1 +
 2 files changed, 81 insertions(+)