Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 662382 - =media-sound/lmms-1.2.0: add USE="mp3"
Summary: =media-sound/lmms-1.2.0: add USE="mp3"
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Alexis Ballier
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2018-07-29 01:26 UTC by Enne Eziarc
Modified: 2018-10-03 23:37 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Add USE=mp3 to lmms.ebuild (lmms-9999.ebuild.patch,848 bytes, patch)
2018-07-29 01:26 UTC, Enne Eziarc
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Enne Eziarc 2018-07-29 01:26:05 UTC
Created attachment 541590 [details, diff]
Add USE=mp3 to lmms.ebuild

Current latest release is 1.2.0_rc6, renaming the ebuild works for me.

Also it looks like 1.2.0_rc4 added libmp3lame support; without a corresponding USE flag it adds an automagic dependency. Patch to fix that is enclosed.
Comment 1 Larry the Git Cow gentoo-dev 2018-08-14 08:42:28 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=26a2908ebc0b76189b9c3868b936a49622e8cd16

commit 26a2908ebc0b76189b9c3868b936a49622e8cd16
Author:     Anthony Parsons <ant+gentoo.bugs@flussence.eu>
AuthorDate: 2018-08-14 08:38:40 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2018-08-14 08:42:21 +0000

    media-sound/lmms: Added mp3 USE flag.
    
    Bug: https://bugs.gentoo.org/662382
    Package-Manager: Portage-2.3.46, Repoman-2.3.10

 media-sound/lmms/lmms-9999.ebuild | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Comment 2 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2018-08-14 08:45:18 UTC
I wonder how you managed to get >=lmms-1.2.0_rc5 compiling. Upstream stupidly added third party stuff which needs to be fetched and put into the source directory structure before the build succeeds:

CMake Error at src/3rdparty/CMakeLists.txt:6 (add_subdirectory):
  The source directory

/var/tmp/portage/media-sound/lmms-1.2.0_rc6/work/lmms-1.2.0-rc6/src/3rdparty
/qt5-x11embed

  does not contain a CMakeLists.txt file.
Comment 3 Enne Eziarc 2018-08-15 11:05:27 UTC
(In reply to Lars Wendler (Polynomial-C) from comment #2)
> I wonder how you managed to get >=lmms-1.2.0_rc5 compiling.
I probably should've tested further than "ebuild digest"... my bad :)

The current -rc4/9999 ebuilds work fine, at least; if anyone wants -rc6 specifically they know how to use EGIT_COMMIT.

Should we remove the version bump from this bug and mark it solved? Can file a new one if 1.2.0 is released still broken.
Comment 4 Andreas Sturmlechner gentoo-dev 2018-10-03 23:37:13 UTC
(In reply to Anthony Parsons from comment #3)
> Should we remove the version bump from this bug and mark it solved?
Doing exactly that, thanks.