Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 662178 - media-plugins/vdr-{live,vdrmanager}: invalid use of path_exists
Summary: media-plugins/vdr-{live,vdrmanager}: invalid use of path_exists
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal QA (vote)
Assignee: Gentoo VDR Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-26 11:39 UTC by Michał Górny
Modified: 2018-08-15 07:31 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-07-26 11:39:07 UTC
media-plugins/vdr-live/vdr-live-2.3.1.ebuild:           if path_exists -a "${ROOT}"/etc/vdr/plugins/live/live.pem; then


This makes no sense.  The only use for path_exists is to handle globs that might expand into multiple files (which can not work with regular [[ -f ... ]]).
Comment 1 Larry the Git Cow gentoo-dev 2018-08-15 07:31:06 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6120cd42a749a0872d22eb15cbc09fe98f92723e

commit 6120cd42a749a0872d22eb15cbc09fe98f92723e
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2018-08-08 21:15:24 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2018-08-15 07:30:53 +0000

    media-plugins/vdr-vdrmanager: Replace unnecessary path_exists call
    
    Replace the unnecessary path_exists calls with plain bash -f test.
    The path_exists function was only intended to be used when necessary
    to deal with wildcards.
    
    Closes: https://bugs.gentoo.org/662178

 media-plugins/vdr-vdrmanager/vdr-vdrmanager-0.14.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6b861b6f5df522ec7e662150d3c6b9f213a5ef18

commit 6b861b6f5df522ec7e662150d3c6b9f213a5ef18
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2018-08-08 21:14:05 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2018-08-15 07:30:53 +0000

    media-plugins/vdr-live: Replace unnecessary path_exists calls
    
    Replace the unnecessary path_exists calls with plain bash -f test.
    The path_exists function was only intended to be used when necessary
    to deal with wildcards.
    
    Bug: https://bugs.gentoo.org/662178

 media-plugins/vdr-live/vdr-live-0.3.0_p20130504-r1.ebuild | 2 +-
 media-plugins/vdr-live/vdr-live-0.3.0_p20130504-r2.ebuild | 2 +-
 media-plugins/vdr-live/vdr-live-2.3.1.ebuild              | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)