Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 662112 - mail-filter/opendmarc-1.3.2-r1: /lib/systemd/system/opendmarc.service:4: Missing '=' (systemd-238)
Summary: mail-filter/opendmarc-1.3.2-r1: /lib/systemd/system/opendmarc.service:4: Miss...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Fabian Groffen
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-25 14:22 UTC by Leho Kraav (:macmaN @lkraav)
Modified: 2018-12-10 10:35 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Leho Kraav (:macmaN @lkraav) 2018-07-25 14:22:11 UTC
It looks like w/ systemd-238 (or slightly earlier) the work done in bug 622606 may have become stale, service won't start.

```
[Unit]                                                                                                                            
Description=Domain-based Message Authentication, Reporting and Conformance (DMARC) Milter                                         
Documentation=man:opendmarc(8) man:opendmarc.conf(5) man:opendmarc-expire(8) man:opendmarc-importstats(8) man:opendmarc-reports(8)
man:opendmarc-check(8) man:opendmarc-import(8) man:opendmarc-params(8) http://www.trusteddomain.org/opendmarc/                    
After=network.target nss-lookup.target syslog.target
```

L4 seems to be a part of an incorrectly wrapped `Documentation` parameter value.

https://gitweb.gentoo.org/repo/gentoo.git/diff/?id=b2eab8cee39c59cc922c73f830ccfbc021d8e562 does look weird to me.

Fabian, your thoughts?
Comment 1 Fabian Groffen gentoo-dev 2018-12-10 10:13:27 UTC
Do you believe the installed systemd file is incorrect?  I have no way to test this, but I'm open for fixing this.
Comment 2 Leho Kraav (:macmaN @lkraav) 2018-12-10 10:28:18 UTC
Yes, it's incorrect. Must make sure `Documentation=` value does not have any linefeeds in it.

Correct copy below:

Documentation=man:opendmarc(8) man:opendmarc.conf(5) man:opendmarc-expire(8) man:opendmarc-importstats(8) man:opendmarc-reports(8) man:opendmarc-check(8) man:opendmarc-import(8) man:opendmarc-params(8) http://www.trusteddomain.org/opendmarc/
Comment 3 Larry the Git Cow gentoo-dev 2018-12-10 10:35:15 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7319c4e904277ecc9ec7fb8f0e1e91dbfdd75546

commit 7319c4e904277ecc9ec7fb8f0e1e91dbfdd75546
Author:     Fabian Groffen <grobian@gentoo.org>
AuthorDate: 2018-12-10 10:34:55 +0000
Commit:     Fabian Groffen <grobian@gentoo.org>
CommitDate: 2018-12-10 10:34:55 +0000

    mail-filter/opendmarc: cleanup and fix bugs #655728, #662112
    
    Bug: https://bugs.gentoo.org/640012
    Closes: https://bugs.gentoo.org/655728
    Closes: https://bugs.gentoo.org/662112
    Signed-off-by: Fabian Groffen <grobian@gentoo.org>
    Package-Manager: Portage-2.3.51, Repoman-2.3.11

 mail-filter/opendmarc/Manifest                     |  2 -
 mail-filter/opendmarc/files/opendmarc.service      |  5 +--
 mail-filter/opendmarc/opendmarc-1.3.0.ebuild       | 51 ----------------------
 ...marc-1.3.1.ebuild => opendmarc-1.3.2-r2.ebuild} | 37 +++++++++++-----
 4 files changed, 29 insertions(+), 66 deletions(-)