Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 662094 - app-text/goldendict-1.5.0_rc2-r2 needs patching for Qt 5.11
Summary: app-text/goldendict-1.5.0_rc2-r2 needs patching for Qt 5.11
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Qt Bug Alias
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: qt-5.11
  Show dependency tree
 
Reported: 2018-07-25 12:27 UTC by Viacheslav Ostroukh
Modified: 2018-08-17 22:03 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Proposed patch (headers.patch,1.10 KB, patch)
2018-07-25 12:27 UTC, Viacheslav Ostroukh
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Viacheslav Ostroukh 2018-07-25 12:27:05 UTC
Created attachment 540990 [details, diff]
Proposed patch

I think these changes are already in the master, but not yet released. Some Qt includes need to be added to headers. Proposed patch attached.
Comment 1 Toralf Förster gentoo-dev 2018-07-30 16:20:48 UTC
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

In file included from ftshelpers.hh:12:0,
                 from bgl.cc:16:
fulltextsearch.hh:208:11: error: field ‘helpAction’ has incomplete type ‘QAction’
   QAction helpAction;
           ^~~~~~~~~~
In file included from /usr/include/qt5/QtGui/qtextlayout.h:49:0,



at tinderbox image 17.0-developer_20180727-195601
Comment 2 Viktor Levin 2018-08-04 16:04:53 UTC
That patch works, thanks!
Comment 3 Andreas Sturmlechner gentoo-dev 2018-08-17 21:36:15 UTC
Thanks for your reports!

(In reply to Viacheslav Ostroukh from comment #0)
> Created attachment 540990 [details, diff] [details, diff]
> I think these changes are already in the master, but not yet released.
If you *think* they are already in master, please check it (otherwise there is a good opportunity to push your changes to master and get credited as author). Then if you *know* they are already in master, please take them directly from their git; we use upstream's patches if they exist.

Upstream commits:
3d4a468b6c8cb154c88cf4592a5845973999dc29
a65967805ab424b299bdfa1d1f9c7ebb8a7fd517
Comment 4 Larry the Git Cow gentoo-dev 2018-08-17 22:03:58 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=80fbdf3ca74c97e0b1435a178cbf5d7b60ade213

commit 80fbdf3ca74c97e0b1435a178cbf5d7b60ade213
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2018-08-17 21:40:45 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-08-17 22:02:02 +0000

    app-text/goldendict: Fix build with Qt 5.11
    
    Reported-by: Viacheslav Ostroukh <slava@ostroukh.me>
    Tested-by: Viktor Levin <viklevin2@mail.ru>
    Closes: https://bugs.gentoo.org/662094
    Package-Manager: Portage-2.3.46, Repoman-2.3.10

 .../files/goldendict-1.5.0-qt-5.11.patch           | 56 ++++++++++++++++++++++
 app-text/goldendict/goldendict-1.5.0_rc2-r2.ebuild |  5 +-
 2 files changed, 60 insertions(+), 1 deletion(-)