Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 662090 - sys-apps/file-5.34[python] fails to build due to missing readme.md file
Summary: sys-apps/file-5.34[python] fails to build due to missing readme.md file
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-25 11:31 UTC by Mike Auty (RETIRED)
Modified: 2018-07-25 11:55 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Auty (RETIRED) gentoo-dev 2018-07-25 11:31:02 UTC
Hiya,

I just tried building file-5.34 with python support, and got the following during the python build phase:

make[1]: Leaving directory '/var/tmp/portage/sys-apps/file-5.34/work/file-5.34-abi_x86_64.amd64'
 * python2_7: running distutils-r1_run_phase distutils-r1_python_compile
python2.7 setup.py build
Traceback (most recent call last):
  File "setup.py", line 7, in <module>
    with open('README.md', 'r') as fh:
IOError: [Errno 2] No such file or directory: u'README.md'

Investigating this, it appears to from the following line in the ebuild:

	# don't let python README kill main README #60043
	mv python/README.md README.python.md || die

Which in 5.33-r4 read:

	# don't let python README kill main README #60043
	mv python/README{,.python} || die

So the first issue is the file is now moved to ${S} rather than ${S}/python, the second is that the references to it (in setup.py and the various automake files) don't include the change from README.md to README.python.md.

It turns out that only the python README is now a .md file, which means that the whole line could be removed and install the README and README.md without overlap.  However, in case they change the main readme to markdown, it might still be worth renaming the file.  In that case, the code would also need patching as well as simply doing the rename in the ebuild, to ensure that the python readme is properly named and installs correctly.

Let me know if you need any further information...
Comment 1 Larry the Git Cow gentoo-dev 2018-07-25 11:55:37 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8b66dfac4898666bd95c77dde05e1f0b973f4b42

commit 8b66dfac4898666bd95c77dde05e1f0b973f4b42
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2018-07-25 11:55:27 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2018-07-25 11:55:27 +0000

    sys-apps/file: Fixed installation with USE="python"
    
    Closes: https://bugs.gentoo.org/662090
    Package-Manager: Portage-2.3.43, Repoman-2.3.10

 sys-apps/file/file-5.34.ebuild | 3 ++-
 sys-apps/file/file-9999.ebuild | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)