Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 662056 - gnome-extra/gnome-shell-extension-gsconnect-11: wrong nautilus-python dependency
Summary: gnome-extra/gnome-shell-extension-gsconnect-11: wrong nautilus-python dependency
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Pacho Ramos
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-24 23:06 UTC by Mart Raudsepp
Modified: 2019-01-05 13:24 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mart Raudsepp gentoo-dev 2018-07-24 23:06:40 UTC
gnome-extra/gnome-shell-extension-gsconnect doesn't seem to use nautilus-python anywhere in its code. It uses "from gi.repository import Nautilus", for which it needs gnome-base/nautilus[introspection], not deprecated nautilus-python.

Folks is also used via introspection, but introspection isn't optional for dev-libs/folks, so that's fine.

Both seem to be runtime optional deps, maybe some would like to use the extension without those deps, especially folks (harder to imagine gnome-shell without nautilus, while folks is just pulled in otherwise via extra apps like Contacts and Maps)
Comment 1 Mart Raudsepp gentoo-dev 2018-07-24 23:07:11 UTC
Oh, and otherwise I'm already using it, thanks for packaging it :)
Comment 2 Pacho Ramos gentoo-dev 2018-07-25 08:13:06 UTC
Ah, for nautilus-python I got confused because of the name of the packages that were suggested for other distributions

For gnome-online-accounts and folks for contacts integration... it should allow either folks or either gnome-online-accounts+libgdata (I got a bit confused as I thought they were covering contacts from different sources and, hence, I preferred to pull both to cover all the contacts instead some missing)
Comment 3 Pacho Ramos gentoo-dev 2018-07-25 09:21:26 UTC
[master 625047b1df41] gnome-extra/gnome-shell-extension-gsconnect: Fix dependencies (#662056 by leio)
 1 file changed, 5 insertions(+), 8 deletions(-)
 rename gnome-extra/gnome-shell-extension-gsconnect/{gnome-shell-extension-gsconnect-11.ebuild => gnome-shell-extension-gsconnect-11-r1.ebuild} (86%)
Comment 4 Mart Raudsepp gentoo-dev 2018-12-08 17:30:03 UTC
I was wrong and operated under the wrong assumption that nautilus-python is an old-style python binding. But nautilus-python doesn't provide any bindings - it provides a C nautilus extension that supports extending nautilus from python.
Therefore without nautilus-python gnome-shell-extension-gsconnect works fine in general, BUT the nautilus integration can't work - the "Send To Mobile Device" context menu (right click) item won't be available to directly send files from nautilus to a mobile device.
Unless things were handled different in v12, the nautilus-python dep should be added back.

Also there's no PYTHON_COMPAT handling, but that's probably fine and the python extension just has to work with the python version that nautilus-python is built with, and that in turn probably has to be python-single-r1 anyways.
Comment 5 Larry the Git Cow gentoo-dev 2019-01-05 13:24:42 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f092759882b6f8ce538dcebfac1b50b004e56cdd

commit f092759882b6f8ce538dcebfac1b50b004e56cdd
Author:     Pacho Ramos <pacho@gentoo.org>
AuthorDate: 2019-01-05 13:09:01 +0000
Commit:     Pacho Ramos <pacho@gentoo.org>
CommitDate: 2019-01-05 13:09:01 +0000

    gnome-extra/gnome-shell-extension-gsconnect: It really needs nautilus-python
    
    Thanks-to: leio
    Closes: https://bugs.gentoo.org/662056
    Package-Manager: Portage-2.3.53, Repoman-2.3.12
    Signed-off-by: Pacho Ramos <pacho@gentoo.org>

 ...sconnect-12.ebuild => gnome-shell-extension-gsconnect-12-r1.ebuild} | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)