snes9x can build a libretro core, therefore a "libretro" use flag should be added that optionally builds it. A libretro core is just a shared library (in this case, it'll end up at /usr/lib64/libretro_snes9x.so). To build it, "make && make install" needs to be run in the libretro subdirectory.
Before I commit, I just curious about the gtk flag usage in RDEPEND. If we don't specify 'gtk' while building, the build will fail anyway because it doesn't have headers from x11-libs/libXv. Is there any other reasoning the ebuild is written in the current way?
Could you give a little more background here? Should we just be dropping the standalone package in favour of this? If the standalone package just uses sources that originate from snes9x upstream anyway then there seems little point in keeping it. I'll check out the libXv dependency when I have a closer look.
Now that you mention it, I thought about it a tiny bit as well when researching snes9x and the snes9x libretro build. From it seems that libretro was forked from snes9x and had some changes as well. Now libretro is doing a PR back to snes9x. My conclusion from that: libretro git repository/libretro-snes9x package is most up to date due to having the most users (since kodi-game-libretro-snes9x is dependant on libretro-snes9x). I would suggest that I keep the "libretro" flag but a) it only installs the libretro-snes9x package as a dependency, nothing more. or b) we drop the libretro-snes9x and it clones the current libretro repo. What about other similar cases then, nestopia and dosbox - they have both stand-alone and libretro packages in the main repo?
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=51deb2b497294bd8e1a1e72532411a006f6c427d commit 51deb2b497294bd8e1a1e72532411a006f6c427d Author: Henrik Pihl <ahvenas@gmail.com> AuthorDate: 2020-07-25 19:52:39 +0000 Commit: Craig Andrews <candrews@gentoo.org> CommitDate: 2020-08-13 20:50:32 +0000 games-emulation/snes9x: libretro use flag for optional build Fixed dependency list to enable build without gtk. Package now hardblocks games-emulation/libretro-snes9x when libretro is selected. Closes: https://bugs.gentoo.org/661936 Package-Manager: Portage-3.0.0, Repoman-2.3.23 Signed-off-by: Henrik Pihl <ahvenas@gmail.com> Signed-off-by: Craig Andrews <candrews@gentoo.org> games-emulation/snes9x/metadata.xml | 1 + games-emulation/snes9x/snes9x-1.60.ebuild | 26 ++++++++++++++++++-------- 2 files changed, 19 insertions(+), 8 deletions(-) Additionally, it has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0ffd5ef7e86800c064c0ebe9b5ad9d586fc94a36 commit 0ffd5ef7e86800c064c0ebe9b5ad9d586fc94a36 Author: Henrik Pihl <ahvenas@gmail.com> AuthorDate: 2020-07-25 19:49:19 +0000 Commit: Craig Andrews <candrews@gentoo.org> CommitDate: 2020-08-13 20:50:31 +0000 games-emulation/libretro-snes9x: block games-emulation/snes9x[libretro] Only from >=1.60, earlier are left untouched. Bug: https://bugs.gentoo.org/661936 Package-Manager: Portage-3.0.0, Repoman-2.3.23 Signed-off-by: Henrik Pihl <ahvenas@gmail.com> Closes: https://github.com/gentoo/gentoo/pull/16818 Signed-off-by: Craig Andrews <candrews@gentoo.org> games-emulation/libretro-snes9x/Manifest | 1 + .../libretro-snes9x-0.0.2_pre20200107.ebuild | 17 +++++++++++++++++ 2 files changed, 18 insertions(+)
