Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 661864 - media-libs/imlib2 enable X and shm flags by default
Summary: media-libs/imlib2 enable X and shm flags by default
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Joonas Niilola
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-23 09:32 UTC by Jan Psota
Modified: 2018-08-23 12:32 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Psota 2018-07-23 09:32:30 UTC
1. Packages rather depend on setting X in imlib2:
$ equery d imlib2
 * These packages depend on imlib2:
media-gfx/feh-2.27 (media-libs/imlib2[X])
media-gfx/qiv-2.3.2 (media-libs/imlib2[X])
www-client/w3m-0.5.3_p20180125 (imlib ? media-libs/imlib2[X?])

2. "Imlib has support for the MIT-SHM extension via shared images to speed up rendering." - if it works now, why shouldn't we use it by default? :-)
Comment 1 Joonas Niilola gentoo-dev 2018-07-23 12:29:22 UTC
(In reply to Jan Psota from comment #0)
> 1. Packages rather depend on setting X in imlib2:
> $ equery d imlib2
>  * These packages depend on imlib2:
> media-gfx/feh-2.27 (media-libs/imlib2[X])
> media-gfx/qiv-2.3.2 (media-libs/imlib2[X])
> www-client/w3m-0.5.3_p20180125 (imlib ? media-libs/imlib2[X?])

There are many, many many more packages in the tree that don't require imlib2[X]. However looks like majority does. I believe imlib2 still works in headless systems that probably have set -X in their make.conf. If 'shm' was enabled by default, it would stop the update requiring 'X' to be set, or 'shm' to be unset for this package. I do agree 'shm' is a bit hidden now, and probably no one has it enabled. 

> 
> 2. "Imlib has support for the MIT-SHM extension via shared images to speed
> up rendering." - if it works now, why shouldn't we use it by default? :-)

It still has some issues currently, 
https://phab.enlightenment.org/T7173#121029

but yes it's a nice feature that you probably want enabled if you have X. I'm not sure how to achieve this without making things "problematic" for people with -X by default, since the update would stop here, asking them to modify their package.use for this package. 

However I can only recommend 'shm' to be used when next xorg is released due to issues linked above, so gonna track this bug (and keep it open) until then. I think changing IUSE="+shm +X" should be done, since upstream enables these flags by default too.
Comment 2 Jan Psota 2018-07-23 12:39:52 UTC
Thanks! I understood. I was in doubt, too - maybe in next EAPI there will be capability to automatically enable some use-flag if some other is set. But EAPI is a little complicated now, and rather should not be more.
Comment 3 Larry the Git Cow gentoo-dev 2018-08-23 12:32:14 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=09b0e06d6fdb63a57fd40bfe321ecf3fb794f6e1

commit 09b0e06d6fdb63a57fd40bfe321ecf3fb794f6e1
Author:     Joonas Niilola <juippis@gmail.com>
AuthorDate: 2018-08-17 08:58:52 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2018-08-23 12:32:02 +0000

    media-libs/imlib2: enable 'shm' and 'X' by default in 1.5.1-r1
    
    Closes: https://bugs.gentoo.org/661864
    Closes: https://github.com/gentoo/gentoo/pull/9596
    Package-Manager: Portage[mgorny]-2.3.43.3

 media-libs/imlib2/imlib2-1.5.1-r1.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)