Created attachment 540352 [details] plex-media-server-1.13.4.ebuild Ebuild attached.
Thank you for your contribution. I had a short look on the ebuild. Here a few ideas: * Please test the ebuild with repoman full -x https://wiki.gentoo.org/wiki/Repoman * We always try to use the latest EAPI, please bump to EAPI=7 https://dev.gentoo.org/~mgorny/articles/the-ultimate-guide-to-eapi-7.html * Please remove obsolete lines * Please introduce local variables with "local" ("for f" needs "local f") The SRC_URI looks overcomplicated to me: SRC_URI="amd64? ( ${URI}/${_FULL_VERSION}/plexmediaserver_${_FULL_VERSION}_amd64.deb )" * Please check, if inherit eutils is needed * the ebuild is really hard to read try to tidy it up a bit.
While it is nice and optimistic to always have ebuilds at the latest possible state in terms of code and EAPIs, I would advise against this unless the person knows exactly what they are doing and has done a lot of testing, etc. Updating the ebuilds to much means that we will need to take even longer for us to get the ebuilds into the tree since there could be possible behavior changes within the EAPIs that would manifest later in weird situations. I would encourage sticking to the same design the maintainer has unless specify otherwise by the maintainer. There is already a limited amount of time I can dedicate to Gentoo and worrying about ebuild syntax, EAPI changes, possible repercussions is not something I want to actively pursue if I can avoid it.
For what it's worth, this is identical to what's in portage currently with the only change being the file version info. And the overcomplicated URL line is necessary, given the unusual versioning style and directory structure upstream uses.
Yup this isn't a problem Chris, thanks for the contribution! I'll merge it in when I get some time.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=58fbf17a8c52c49dcfd9568a972b5f9b9a8fd2c2 commit 58fbf17a8c52c49dcfd9568a972b5f9b9a8fd2c2 Author: Tony Vroon <chainsaw@gentoo.org> AuthorDate: 2019-02-08 13:48:38 +0000 Commit: Tony Vroon <chainsaw@gentoo.org> CommitDate: 2019-02-08 13:48:52 +0000 media-tv/plex-media-server: 1.14.1 version bump As per the earlier request by Chris Slycord, bump to most recent version. Taking ebuild review from Jonas Stein into account, bumping EAPI to 7. Various quote-related simplifications as a result. Taking maintainership and assigning bugs to me. Closes: https://bugs.gentoo.org/661734 Signed-Off-By: Tony Vroon <chainsaw@gentoo.org> Package-Manager: Portage-2.3.51, Repoman-2.3.11 media-tv/plex-media-server/Manifest | 1 + media-tv/plex-media-server/metadata.xml | 5 +- .../plex-media-server-1.14.1.ebuild | 161 +++++++++++++++++++++ 3 files changed, 166 insertions(+), 1 deletion(-)
