Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 660772 - sys-apps/gptfdisk gained unnecessary unconditional dependency on sys-libs/ncurses[static-libs]
Summary: sys-apps/gptfdisk gained unnecessary unconditional dependency on sys-libs/ncu...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: Lars Wendler (Polynomial-C) (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-09 09:52 UTC by Marien Zwart
Modified: 2018-07-09 10:58 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info '=gptfdisk-1.0.3' (emerge-info.txt,6.95 KB, text/plain)
2018-07-09 09:52 UTC, Marien Zwart
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Marien Zwart 2018-07-09 09:52:06 UTC
Created attachment 538892 [details]
emerge --info '=gptfdisk-1.0.3'

The fix for bug 513868 accidentally made gptfdisk's dependency on sys-libs/ncurses[static-libs] unconditional (the dependency is only needed if gptfdisk itself is being built with USE=static):

% emerge -vpt '=gptfdisk-1.0.3'
...
[ebuild   R    ] sys-apps/gptfdisk-1.0.3::gentoo  USE="ncurses -static" 0 KiB
[ebuild   R    ]  sys-libs/ncurses-6.1-r3:0/6::gentoo  USE="cxx doc static-libs* unicode -ada -debug -gpm -minimal -profile {-test} -threads -tinfo -trace" ABI_X86="(64) -32 (-x32)" 0 KiB

The problem is that the ebuild uses string substitution to remove "[static-libs(+)]" from LIB_DEPEND (RDEPEND="!static? ( ${LIB_DEPEND//\[static-libs(+)]} )"), and 50001c50b70e0efe708b5c2a57fbe1e32ad207f6 changed LIB_DEPEND's ">=sys-libs/ncurses-5.7-r7:0=[static-libs(+)]" to ">=sys-libs/ncurses-5.7-r7:0=[unicode,static-libs(+)" (so the substitution no longer matches).
Comment 2 Marien Zwart 2018-07-09 09:59:51 UTC
You're fast! I swear that commit wasn't there yet when I started entering this bug report :)
Comment 3 Larry the Git Cow gentoo-dev 2018-07-09 10:58:33 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=91c0efc19c4cc6b6f0e80024c8ee34485454bdcb

commit 91c0efc19c4cc6b6f0e80024c8ee34485454bdcb
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2018-07-09 10:58:12 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2018-07-09 10:58:27 +0000

    sys-apps/gptfdisk: Really fix static dependencies this time.
    
    Closes: https://bugs.gentoo.org/660772
    Package-Manager: Portage-2.3.41, Repoman-2.3.9

 sys-apps/gptfdisk/gptfdisk-1.0.1.ebuild | 16 ++++++++++------
 sys-apps/gptfdisk/gptfdisk-1.0.3.ebuild | 17 ++++++++++-------
 sys-apps/gptfdisk/gptfdisk-1.0.4.ebuild | 17 ++++++++++-------
 3 files changed, 30 insertions(+), 20 deletions(-)