Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 660586 - dev-qt/qtwebengine has unused dependency on dev-libs/protobuf:=
Summary: dev-qt/qtwebengine has unused dependency on dev-libs/protobuf:=
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Qt Bug Alias
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-07 08:28 UTC by Arfrever Frehtes Taifersar Arahesis
Modified: 2018-09-13 21:23 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis 2018-07-07 08:28:11 UTC
dev-qt/qtwebengine (at least recent versions) actually uses bundled copy of protobuf from src/3rdparty/chromium/third_party/protobuf directory.
So dependency on dev-libs/protobuf:= in ebuilds is probably incorrect.

(www-client/chromium also uses bundled copy of protobuf.)

dev-qt/qtwebengine 5.9.* and 5.10.* contain protobuf 3.0.0.
dev-qt/qtwebengine 5.11.* contains protobuf 3.3.2.
Comment 1 Denis Descheneaux 2018-07-07 13:17:32 UTC
Fails to build with dev-libs/protobuf-3.6.0.1 installed

Genlop output for both packages:

     Mon Jan 29 21:01:24 2018 >>> dev-libs/protobuf-3.5.1.1
     Fri Mar  9 18:14:03 2018 >>> dev-libs/protobuf-3.5.2
     Tue Jun 26 13:18:01 2018 >>> dev-qt/qtwebengine-5.9.6
     Thu Jun 28 10:38:50 2018 >>> dev-qt/qtwebengine-5.9.6-r1
     Tue Jul  3 18:12:45 2018 >>> dev-qt/qtwebengine-5.11.1
     Sat Jul  7 04:37:48 2018 >>> dev-libs/protobuf-3.6.0.1


[12264/15449] /usr/bin/x86_64-pc-linux-gnu-g++ -MMD -MF obj/content/public/network/network_sources/ignore_errors_cert_verifier.o.d -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_AURA=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DNO_TCMALLOC -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -DTOOLKIT_QT -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DCONTENT_IMPLEMENTATION -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_32 -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_26 -DGL_GLEXT_PROTOTYPES -DUSE_GLX -DUSE_EGL -DUSING_SYSTEM_ICU=1 -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DLEVELDB_PLATFORM_CHROMIUM=1 -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_HAS_PNG_LIBRARY -DSK_HAS_WEBP_LIBRARY -DSK_HAS_JPEG_LIBRARY -DSK_SUPPORT_GPU=1 -DUSING_SYSTEM_ICU=1 -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC -Igen -I../../3rdparty/chromium -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -Igen -Igen -Igen -Igen -Igen -Igen -Igen -Igen -I../../3rdparty/chromium/third_party/khronos -I../../3rdparty/chromium/gpu -I../../3rdparty/chromium/third_party/libyuv/include -Igen -Igen -Igen -Igen -Igen -I../../3rdparty/chromium/third_party/ced/src -I../../3rdparty/chromium/third_party/protobuf/src -I../../3rdparty/chromium/third_party/leveldatabase -I../../3rdparty/chromium/third_party/leveldatabase/src -I../../3rdparty/chromium/third_party/leveldatabase/src/include -I../../3rdparty/chromium/third_party/protobuf/src -Igen/protoc_out -I../../3rdparty/chromium/third_party/boringssl/src/include -I/usr/include/nss -I/usr/include/nspr -Igen -I../../3rdparty/chromium/skia/config -I../../3rdparty/chromium/skia/ext -I../../3rdparty/chromium/third_party/skia/include/c -I../../3rdparty/chromium/third_party/skia/include/config -I../../3rdparty/chromium/third_party/skia/include/core -I../../3rdparty/chromium/third_party/skia/include/effects -I../../3rdparty/chromium/third_party/skia/include/encode -I../../3rdparty/chromium/third_party/skia/include/gpu -I../../3rdparty/chromium/third_party/skia/include/images -I../../3rdparty/chromium/third_party/skia/include/lazy -I../../3rdparty/chromium/third_party/skia/include/pathops -I../../3rdparty/chromium/third_party/skia/include/pdf -I../../3rdparty/chromium/third_party/skia/include/pipe -I../../3rdparty/chromium/third_party/skia/include/ports -I../../3rdparty/chromium/third_party/skia/include/utils -I../../3rdparty/chromium/third_party/vulkan/include -I../../3rdparty/chromium/third_party/skia/src/gpu -I../../3rdparty/chromium/third_party/skia/src/sksl -I../../3rdparty/chromium/third_party/libwebm/source -I../../3rdparty/chromium/third_party/WebKit -Igen/third_party/WebKit -I../../3rdparty/chromium/v8/include -Igen/v8/include -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe -pthread -m64 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wno-unused-local-typedefs -Wno-maybe-uninitialized -Wno-deprecated-declarations -fno-delete-null-pointer-checks -Wno-missing-field-initializers -Wno-unused-parameter -O2 -fno-ident -fdata-sections -ffunction-sections -fno-omit-frame-pointer -g0 -fvisibility=hidden -std=gnu++14 -fno-delete-null-pointer-checks -Wno-narrowing -fno-exceptions -fno-rtti -fvisibility-inlines-hidden -c ../../3rdparty/chromium/content/public/network/ignore_errors_cert_verifier.cc -o obj/content/public/network/network_sources/ignore_errors_cert_verifier.o
../../3rdparty/chromium/base/time/time.h:58:10: fatal error: limits: No such file or directory
Comment 2 josef.95 2018-07-07 17:13:10 UTC
(In reply to Denis Descheneaux from comment #1)
> Fails to build with dev-libs/protobuf-3.6.0.1 installed
> 
[...]

I can not reproduce this, builds here fine.


[ebuild   R    ] dev-libs/protobuf-3.6.0.1:0/16::gentoo  USE="zlib -emacs -examples -static-libs {-test}" ABI_X86="(64) -32 (-x32)" 0 KiB
[ebuild   R    ] dev-qt/qtwebengine-5.11.1:5/5.11::gentoo  USE="alsa pulseaudio system-ffmpeg system-icu widgets -bindist -debug -designer -geolocation -pax_kernel {-test}" 0 KiB
Comment 3 Denis Descheneaux 2018-07-07 22:13:54 UTC
Followed the suggestion here by uninstalling it first and then emerging it clean, and it went it, looks like if you look at the ebuild that it uses headers etc outside the package build itself

https://bugreports.qt.io/browse/QTBUG-58547
Comment 4 Denis Descheneaux 2018-07-07 23:18:39 UTC
	# bug 620444 - ensure local headers are used
	find "${S}" -type f -name "*.pr[fio]" | xargs sed -i -e 's|INCLUDEPATH += |&$$QTWEBENGINE_ROOT/include |' || die
Comment 5 Larry the Git Cow gentoo-dev 2018-07-12 10:38:15 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=788a887f418635c64ef058b12f541601363c3321

commit 788a887f418635c64ef058b12f541601363c3321
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2018-07-07 08:39:50 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-07-12 09:59:31 +0000

    dev-qt/qtwebengine: Drop unused dependency
    
    (Unfortunately) it currently uses chromium's bundled protobuf.
    
    Thanks-to: Arfrever Frehtes Taifersar Arahesis <arfrever.fta@gmail.com>
    Bug: https://bugs.gentoo.org/660586
    Package-Manager: Portage-2.3.41, Repoman-2.3.9

 dev-qt/qtwebengine/qtwebengine-5.11.1.ebuild   | 1 -
 dev-qt/qtwebengine/qtwebengine-5.9.6-r1.ebuild | 1 -
 2 files changed, 2 deletions(-)
Comment 6 Arfrever Frehtes Taifersar Arahesis 2018-09-13 21:23:09 UTC
https://gitweb.gentoo.org/proj/qt.git/commit/?id=e389555ec66d89f4d0fed7a9d75a3deeada7fce7

commit e389555ec66d89f4d0fed7a9d75a3deeada7fce7
Author:     Jimi Huotari <chiitoo@gentoo.org>
AuthorDate: Thu Jul 25 23:11:33 2018 +0000
Commit:     Jimi Huotari <chiitoo@gentoo.org>
CommitDate: Thu Jul 25 23:15:28 2018 +0000

    dev-qt/qtwebengine: sync with main Gentoo repo tree
    
    Package-Manager: Portage-2.3.43, Repoman-2.3.10