Upstream's prebuilt stages do not inherit rust-docs for armv6 and armv7, so please mask the useflag for rust-bin via profiles. Error message from emerge looks like this: >>> Preparing source in /var/tmp/portage/dev-lang/rust-bin-1.26.2/work/rust-bin-1.26.2 ... >>> Source prepared. >>> Configuring source in /var/tmp/portage/dev-lang/rust-bin-1.26.2/work/rust-bin-1.26.2 ... >>> Source configured. >>> Compiling source in /var/tmp/portage/dev-lang/rust-bin-1.26.2/work/rust-bin-1.26.2 ... >>> Source compiled. >>> Test phase [not enabled]: dev-lang/rust-bin-1.26.2 >>> Install rust-bin-1.26.2 into /var/tmp/portage/dev-lang/rust-bin-1.26.2/image/ category dev-lang install: error: unknown component: rust-docs * ERROR: dev-lang/rust-bin-1.26.2::gentoo failed (install phase): * (no error message) * * Call stack: * ebuild.sh, line 124: Called src_install * environment, line 2147: Called die * The specific snippet of code: * ./install.sh --components="${components}" --disable-verify --prefix="${D}/opt/${P}" --mandir="${D}/usr/share/${P}/man" --disable-ldconfig || die;
I talked with upstream, they claim that the lack of rust-docs is intentional for all archs but x86_64. As a precautious action, the doc useflag should be masked for all but for amd64 via profiles, and for both dev-lang/rust-bin and dev-lang/rust, because it's propaply impossible to build rust-docs without it being included in the stage, right?
Guys, can you please commit the mask? This is really low hanging fruit! :-)
ping!
This would be easier if you provided a patch or a GitHub PR instead of just pointing out literal changes that would be made. Can you do that? Thanks!
ok, I wrote a mask and pinged you on gentoo's github.
Sorry, so I wanted to understand a bit more about the rationale. Where/when did you talk to upstream? In fact rust-docs is not only being generated for amd64, but also other arches like i386-apple-ios (which seems fairly obscure) and i586-pc-windows-msvc. They also still have i686-unknown-linux-gnu, which we should probably use for x86? So the patches as is are wrong, I think. I opened an upstream issue to discuss at https://github.com/rust-lang/rust/issues/53070, too (before I noticed that you'd already talked to them).
Upstream said, they don't build doc anymore for armv6/7: https://github.com/rust-lang/rust/issues/52133#issuecomment-403227065 Honestly, I forgot that x86 still is a thing. Just downloading a stage to see if there is a rust-docs folder, if so I'll add the unmask entry for x86 as well in the pr.
I think the mask should be raised up to >=dev-lang/rust{-bin}-1.27.2 to reflect CVE-2018-1000622
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f2962e61955c40bc8c1b637f66e76e27755fc1b6 commit f2962e61955c40bc8c1b637f66e76e27755fc1b6 Author: Dirkjan Ochtman <djc@gentoo.org> AuthorDate: 2018-09-29 13:19:55 +0000 Commit: Dirkjan Ochtman <djc@gentoo.org> CommitDate: 2018-09-29 13:22:15 +0000 profiles: mask rust docs on arm64 Closes: https://bugs.gentoo.org/660512 Signed-off-by: Dirkjan Ochtman <djc@gentoo.org> profiles/arch/arm64/package.use.mask | 5 +++++ 1 file changed, 5 insertions(+)
Can you please take care of rust-bin and arm as well, please? mask for dev-lang/rust on arm would be great as a precaution, I still have it on my list to patch the ebuild accordingly.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c4352e21e506526e50718a675396f870fa9e123f commit c4352e21e506526e50718a675396f870fa9e123f Author: Dirkjan Ochtman <djc@gentoo.org> AuthorDate: 2018-09-29 18:41:43 +0000 Commit: Dirkjan Ochtman <djc@gentoo.org> CommitDate: 2018-09-29 18:42:22 +0000 profiles: mask rust-bin[doc] on arm64, too Bug: https://bugs.gentoo.org/660512 Signed-off-by: Dirkjan Ochtman <djc@gentoo.org> profiles/arch/arm64/package.use.mask | 1 + 1 file changed, 1 insertion(+)
That should take care of rust-bin. I really don't want to put masks in there for arches that currently aren't keyworded, we can add those as we keyword the ebuilds.
Ah, okay, you've got a point here. Even though it's common practice to mask a use flag for all profiles, and unmask it for those where it's considered to be stable. In the end it doesn't make a difference for the users. regarding arm keywords, #657584 should take care of that, but is ignored by the arm team. The rules for keywording arm are that it has to be compiled successfully once with either armv6 or armv7, getting a package stable on arm would require actuall runtime testing and compile with all harf/soft/armv6/7/fpu-options, etc, pp. If this is correct, I could take over 657584 and do the testing instead of. Just tell me which virtual you're aiming for.
Bug 666976 is stabilizing 1.29.1 for amd64/x86.
It's solely about getting a ~arm keyword for those mentioned in #657584 I can do a testrun for 1.29.1, if you agree to get it keyworded. I mean, the arm team ignores the request in #657584 for three months now?
Keywording is really not up to me, I know ~nothing about arm. It's up to them to prioritize keywording requests and figure out who has time to do something about it.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=beb08d88594ebdb413248786b313395a54b92159 commit beb08d88594ebdb413248786b313395a54b92159 Author: Georgy Yakovlev <gyakovlev@gentoo.org> AuthorDate: 2019-08-28 07:26:46 +0000 Commit: Georgy Yakovlev <gyakovlev@gentoo.org> CommitDate: 2019-08-28 08:24:40 +0000 profiles/arch/arm64/package.use.mask: remove rust-doc masks now masked in base instead Bug: https://bugs.gentoo.org/660512 Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org> profiles/arch/arm64/package.use.mask | 6 ------ 1 file changed, 6 deletions(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a024bd38136b4ffa36205925894ff38d1a9dd057 commit a024bd38136b4ffa36205925894ff38d1a9dd057 Author: Georgy Yakovlev <gyakovlev@gentoo.org> AuthorDate: 2019-08-28 07:23:26 +0000 Commit: Georgy Yakovlev <gyakovlev@gentoo.org> CommitDate: 2019-08-28 08:24:15 +0000 profiles/arch/base/package.use.mask: no docs and tools for rust-bin Bug: https://bugs.gentoo.org/660512 Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org> profiles/arch/base/package.use.mask | 6 ++++++ 1 file changed, 6 insertions(+)
