Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 660270 - games-strategy/s25rttr-0.8.1-r3 : [QA] One or more CMake variables were not used by the project:
Summary: games-strategy/s25rttr-0.8.1-r3 : [QA] One or more CMake variables were not u...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal QA (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2018-07-03 16:55 UTC by Toralf Förster
Modified: 2019-06-09 13:45 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
patch for portage tree (q&a.patch,817 bytes, patch)
2019-05-27 17:38 UTC, tt_1
Details | Diff
patch for ebuild (s25rttr-0.8.1-r3.patch,817 bytes, patch)
2019-06-09 07:01 UTC, tt_1
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2018-07-03 16:55:49 UTC
QA: other
One or more CMake variables were not used by the project:
  COMPILEARCH
QA Notice: Package triggers severe warnings which indicate that it
           may exhibit random runtime failures.
/var/tmp/portage/games-strategy/s25rttr-0.8.1-r3/work/s25rttr-0.8.1/src/GameMessages.h:740:33: warning: ‘<anonymous>.GameMessage_GGSChange::<anonymous>.GameMessage::player’ is used uninitialized in this function [-Wuninitialized]
cc1plus: warning: iteration 31 invokes undefined behavior [-Waggressive-loop-optimizations]
Please do not file a Gentoo bug and instead report the above QA
issues directly to the upstream developers of this software.
Homepage: https://www.siedler25.org/

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.0-desktop-gnome-systemd_test_20180623-161602

  -------------------------------------------------------------------
Comment 1 tt_1 2019-01-31 21:10:53 UTC
I adressed this in https://github.com/gentoo/gentoo/pull/10954
Comment 2 tt_1 2019-05-27 17:38:31 UTC
Created attachment 577892 [details, diff]
patch for portage tree

so, can we go ahead??
Comment 3 tt_1 2019-06-09 07:01:56 UTC
Created attachment 579294 [details, diff]
patch for ebuild

this should fix it
Comment 4 Larry the Git Cow gentoo-dev 2019-06-09 13:45:44 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1015ff7a290da3d5b5fc11c2d840401eb2b483bd

commit 1015ff7a290da3d5b5fc11c2d840401eb2b483bd
Author:     stefson <herrtimson@yahoo.de>
AuthorDate: 2019-01-31 21:07:15 +0000
Commit:     James Le Cuirot <chewi@gentoo.org>
CommitDate: 2019-06-09 13:41:32 +0000

    games-strategy/s25rttr: fix QA issues
    
    Closes: https://bugs.gentoo.org/660270
    
    Signed-off-by: Steffen Kuhn <herrtimson@yahoo.de>
    Closes: https://github.com/gentoo/gentoo/pull/10954
    Signed-off-by: James Le Cuirot <chewi@gentoo.org>

 games-strategy/s25rttr/s25rttr-0.8.1-r3.ebuild | 1 -
 1 file changed, 1 deletion(-)