Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 659930 - media-radio/fldigi one of alsa or oss is required
Summary: media-radio/fldigi one of alsa or oss is required
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Thomas Beierlein
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-03 09:28 UTC by Philippe Trottier
Modified: 2018-08-01 11:35 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
new ebuild with portaudio alsa and oss dependencies (fldigi-4.0.17.ebuild,1.12 KB, text/plain)
2018-07-05 12:11 UTC, Philippe Trottier
Details
media-radio/fldigi-4.0.17 (fldigi-4.0.17.ebuild,1.12 KB, text/plain)
2018-07-05 12:17 UTC, Philippe Trottier
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Trottier 2018-07-03 09:28:47 UTC
If portaudio is present or pulled by fldigi, alsa or possibly oss use flag needs to be present on the portaudio package.

If not it will cause fldigi to segfault at the start.

we can add portaudio use flag, but must make sure it is really not present as the configure.ac will not allow to disable it.

Workaround:

USE=alsa emerge portaudio fldigi
Comment 1 Philippe Trottier 2018-07-05 12:11:55 UTC
Created attachment 538434 [details]
new ebuild with portaudio alsa and oss dependencies

This new ebuild fixes the portaudio issue and allows the use of faster code on some platform

cpu-optimizations needs to be added to the metadata.xml
Comment 2 Philippe Trottier 2018-07-05 12:17:25 UTC
Created attachment 538436 [details]
media-radio/fldigi-4.0.17

Corrected disable oss, tested with 4.0.17 on amd64
Comment 3 Thomas Beierlein gentoo-dev 2018-07-18 15:14:12 UTC
(In reply to Philippe Trottier from comment #2)
> Created attachment 538436 [details]
> media-radio/fldigi-4.0.17
> 
> Corrected disable oss, tested with 4.0.17 on amd64

Thanks for catching the problem and your further work Phillippe. I think we can leave the USE flags for oss and alsa out of the ebuild. It is enough to depend on portaudio to be built with either USE=alsa or USE=oss.

fldigi has also an own oss layer, but that feature can be provided by portaudio.
Comment 4 Thomas Beierlein gentoo-dev 2018-08-01 11:35:02 UTC
(In reply to Philippe Trottier from comment #1)
> Created attachment 538434 [details]
> new ebuild with portaudio alsa and oss dependencies
> 
> This new ebuild fixes the portaudio issue and allows the use of faster code
> on some platform
> 
> cpu-optimizations needs to be added to the metadata.xml

Instead of new USE flag 'cpu-optimizations' we can use the already existing CPU_FLAGS_X86 settings. See actual ebuild in tree.
Comment 5 Larry the Git Cow gentoo-dev 2018-08-01 11:35:33 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=26d5ca6261fee0a9489a248dc38490e6e24c2630

commit 26d5ca6261fee0a9489a248dc38490e6e24c2630
Author:     Thomas Beierlein <tomjbe@gentoo.org>
AuthorDate: 2018-08-01 11:35:10 +0000
Commit:     Thomas Beierlein <tomjbe@gentoo.org>
CommitDate: 2018-08-01 11:35:10 +0000

    media-radio/fldigi: Fix DEPS, honour CPU_FLAGS_X86 settings
    
    Reported-by: Philippe Trottier <tchiwam@gmail.com>
    Closes: https://bugs.gentoo.org/659930
    Package-Manager: Portage-2.3.44, Repoman-2.3.10

 media-radio/fldigi/fldigi-4.0.17.ebuild | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)