Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 659904 - media-gfx/krita with >=media-libs/libraw-0.19.0: kdcraw_p.cpp: error: ‘struct libraw_output_params_t’ has no member named ‘linenoise’
Summary: media-gfx/krita with >=media-libs/libraw-0.19.0: kdcraw_p.cpp: error: ‘struct...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard: tracking upstream
Keywords:
Depends on:
Blocks: libraw-0.19
  Show dependency tree
 
Reported: 2018-07-03 00:10 UTC by Lars Wendler (Polynomial-C) (RETIRED)
Modified: 2018-08-29 16:48 UTC (History)
11 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2018-07-03 00:10:13 UTC
/var/tmp/portage/media-gfx/krita-4.0.3/work/krita-4.0.3/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:381:32: error: ‘struct libraw_output_params_t’ has no member named ‘linenoise’
             raw.imgdata.params.linenoise    = m_parent->m_rawDecodingSettings.NRThreshold * 2.11E-5 + 0.00111111;
                                ^~~~~~~~~
/var/tmp/portage/media-gfx/krita-4.0.3/work/krita-4.0.3/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:382:32: error: ‘struct libraw_output_params_t’ has no member named ‘cfaline’
             raw.imgdata.params.cfaline      = true;
                                ^~~~~~~
/var/tmp/portage/media-gfx/krita-4.0.3/work/krita-4.0.3/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:389:32: error: ‘struct libraw_output_params_t’ has no member named ‘lclean’
             raw.imgdata.params.lclean       = m_parent->m_rawDecodingSettings.NRThreshold     * 5E-5;                                                                                                                                                                       ^~~~~~
/var/tmp/portage/media-gfx/krita-4.0.3/work/krita-4.0.3/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:390:32: error: ‘struct libraw_output_params_t’ has no member named ‘cclean’
             raw.imgdata.params.cclean       = m_parent->m_rawDecodingSettings.NRChroThreshold * 5E-5;
                                ^~~~~~
/var/tmp/portage/media-gfx/krita-4.0.3/work/krita-4.0.3/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:391:32: error: ‘struct libraw_output_params_t’ has no member named ‘cfa_clean’
             raw.imgdata.params.cfa_clean    = true;
                                ^~~~~~~~~
/var/tmp/portage/media-gfx/krita-4.0.3/work/krita-4.0.3/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:398:32: error: ‘struct libraw_output_params_t’ has no member named ‘linenoise’
             raw.imgdata.params.linenoise    = 0;
                                ^~~~~~~~~
/var/tmp/portage/media-gfx/krita-4.0.3/work/krita-4.0.3/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:399:32: error: ‘struct libraw_output_params_t’ has no member named ‘cfaline’
             raw.imgdata.params.cfaline      = false;
                                ^~~~~~~
/var/tmp/portage/media-gfx/krita-4.0.3/work/krita-4.0.3/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:400:32: error: ‘struct libraw_output_params_t’ has no member named ‘lclean’
             raw.imgdata.params.lclean       = 0;
                                ^~~~~~
/var/tmp/portage/media-gfx/krita-4.0.3/work/krita-4.0.3/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:401:32: error: ‘struct libraw_output_params_t’ has no member named ‘cclean’                                                                 raw.imgdata.params.cclean       = 0;
                                ^~~~~~                                                                                                                                                                                                       /var/tmp/portage/media-gfx/krita-4.0.3/work/krita-4.0.3/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:402:32: error: ‘struct libraw_output_params_t’ has no member named ‘cfa_clean’
             raw.imgdata.params.cfa_clean    = false;                                                                                                                                                                                                                        ^~~~~~~~~
/var/tmp/portage/media-gfx/krita-4.0.3/work/krita-4.0.3/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:408:24: error: ‘struct libraw_output_params_t’ has no member named ‘ca_correc’; did you mean ‘exp_correc’?
     raw.imgdata.params.ca_correc  = m_parent->m_rawDecodingSettings.enableCACorrection;
                        ^~~~~~~~~
                        exp_correc
/var/tmp/portage/media-gfx/krita-4.0.3/work/krita-4.0.3/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:409:24: error: ‘struct libraw_output_params_t’ has no member named ‘cared’
     raw.imgdata.params.cared      = m_parent->m_rawDecodingSettings.caMultiplier[0];
                        ^~~~~
/var/tmp/portage/media-gfx/krita-4.0.3/work/krita-4.0.3/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:410:24: error: ‘struct libraw_output_params_t’ has no member named ‘cablue’
     raw.imgdata.params.cablue     = m_parent->m_rawDecodingSettings.caMultiplier[1];
                        ^~~~~~
/var/tmp/portage/media-gfx/krita-4.0.3/work/krita-4.0.3/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:464:24: error: ‘struct libraw_output_params_t’ has no member named ‘eeci_refine’
     raw.imgdata.params.eeci_refine    = m_parent->m_rawDecodingSettings.eeciRefine;
                        ^~~~~~~~~~~
/var/tmp/portage/media-gfx/krita-4.0.3/work/krita-4.0.3/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:465:24: error: ‘struct libraw_output_params_t’ has no member named ‘es_med_passes’; did you mean ‘med_passes’?
     raw.imgdata.params.es_med_passes  = m_parent->m_rawDecodingSettings.esMedPasses;
                        ^~~~~~~~~~~~~
                        med_passes
make[2]: *** [plugins/impex/raw/CMakeFiles/krita_raw_import.dir/build.make:119: plugins/impex/raw/CMakeFiles/krita_raw_import.dir/3rdparty/libkdcraw/src/kdcraw_p.cpp.o] Error 1
make[2]: Leaving directory '/var/tmp/portage/media-gfx/krita-4.0.3/work/krita-4.0.3_build'
make[1]: *** [CMakeFiles/Makefile2:13071: plugins/impex/raw/CMakeFiles/krita_raw_import.dir/all] Error 2
make[1]: Leaving directory '/var/tmp/portage/media-gfx/krita-4.0.3/work/krita-4.0.3_build'
make: *** [Makefile:141: all] Error 2
 * ERROR: media-gfx/krita-4.0.3::gentoo failed (compile phase):
Comment 1 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2018-07-03 08:03:59 UTC
4.1.0 release is also affected. Going to report this to upstream.
Comment 2 Peter Levine 2018-07-04 22:19:10 UTC
There's clearly an API incompatibility with >=libraw-0.19.0.  Many of the missing "struct libraw_output_params_t" members, such as "float linenoise", "int cfaline", etc..., were initially removed from "libraw/libraw_types.h" for 0.19.0-Beta1 (https://github.com/LibRaw/LibRaw/commit/b85690eb4881d613dd48068ee82f98ac246690b8).  In the mean time, kde-apps/libkdcraw and media-gfx/krita should probably change their libraw dependency to 'media-libs/libraw:0/16' or '<media-libs/libraw-0.19.0:='.
Comment 3 Larry the Git Cow gentoo-dev 2018-07-08 16:16:30 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=88d14e3ec154b6d2937d7f7a4615146cdbc8e243

commit 88d14e3ec154b6d2937d7f7a4615146cdbc8e243
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2018-07-08 16:15:06 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-07-08 16:15:30 +0000

    media-gfx/krita: Restrict to <media-libs/libraw-0.19
    
    Bug: https://bugs.gentoo.org/659904
    Package-Manager: Portage-2.3.41, Repoman-2.3.9

 media-gfx/krita/krita-3.3.3.ebuild | 2 +-
 media-gfx/krita/krita-4.0.3.ebuild | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Comment 4 Larry the Git Cow gentoo-dev 2018-08-29 16:48:01 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1073bbaf30c2a586930d2738f9ad958889c64416

commit 1073bbaf30c2a586930d2738f9ad958889c64416
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2018-08-29 16:17:02 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-08-29 16:47:48 +0000

    media-gfx/krita: Fix build with >=libraw-0.19
    
    Reverting 88d14e3.
    
    Closes: https://bugs.gentoo.org/659904
    Package-Manager: Portage-2.3.48, Repoman-2.3.10

 .../krita/files/krita-4.0.3-libraw-0.19.patch      | 77 ++++++++++++++++++++++
 media-gfx/krita/krita-4.0.3.ebuild                 |  4 +-
 2 files changed, 80 insertions(+), 1 deletion(-)