Created attachment 537808 [details] net-irc/quasselgrep-0_p20180521.ebuild There is still not symver for the package. I submitted a pull request to clean up the sed required in the ebuild. related bug 623642
Thank you for your contribution. I had a short look on the ebuild. Here a few ideas: * Please test the ebuild with repoman full -x https://wiki.gentoo.org/wiki/Repoman * please fix the header. (see /usr/portage/skel.ebuild and https://devmanual.gentoo.org/ebuild-writing/eapi/) * Please fix indentation
Thank you for the improvement comments. I will fix and resubmit after python 3.7 is in the tree, and I test it. Be well.
Created attachment 538428 [details] net-irc/quasselgrep-0_p20180531.ebuild This works with python 2.7,3.4,3.5,3.6
Created attachment 538430 [details] net-irc/quasselgrep-9999.ebuild
would you mind to update it to EAPI=7 and push it to github? Automatic tests will prepare the detailed review and merge there. https://wiki.gentoo.org/wiki/Gentoo_GitHub
Created attachment 573416 [details] quasselgrep-9999.ebuild updated .ebuild, supports up to python 3.7
Created attachment 573418 [details] quasselgrep-0_p20190211.ebuild updated, as well.
Comment on attachment 573418 [details] quasselgrep-0_p20190211.ebuild ># Copyright 1999-2019 Gentoo Foundation Old header, it's Authors instead of Foundation nowadays. Repoman should complain about this? ># Distributed under the terms of the GNU General Public License v2 > >EAPI=7 > >PYTHON_COMPAT=( python2_7 python3_{5,6,7} ) > >inherit distutils-r1 > >DESCRIPTION="Tool for searching quassel logs from the commandline" >HOMEPAGE="https://github.com/fish-face/quasselgrep" > >if [[ "${PV}" == "9999" ]] ; then > EGIT_REPO_URI="https://github.com/65278/quasselgrep.git" > inherit git-r3 > KEYWORDS="" >else > MY_COMMIT=9b6b0bc1252daa6e574363d87d04eebd981215a5 > SRC_URI="https://github.com/fish-face/"${PN}"/tarball/"${MY_COMMIT}" -> "${P}".tar.gz" You don't have to break the SRC_URI with unnecessary " " > S=""${WORKDIR}"/fish-face-"${PN}"-"${MY_COMMIT:0:7}"" Same here > KEYWORDS="~amd64 ~x86" >#else ># SRC_URI="https://github.com/fish-face/${PN}/archive/v${PV}.tar.gz -> ${P}.tar.gz" ># KEYWORDS="~amd64 ~x86" You could just remove commented lines, they're just noise. >fi > >LICENSE="GPL-2" >SLOT="0" >IUSE="sqlite postgres" Sort... > >DEPEND="${RDEPEND}" You define RDEPEND below, so how can you inherit its contents here? Besides, setup.py ebuilds usually don't even compile anything, so most likely DEPEND can be dropped from this ebuild altogether. Please check first though. >RDEPEND="sqlite? ( "dev-lang/python[sqlite]" ) I'm not against this, but correct way would probably be to use PYTHON_REQ_USE here > dev-python/python-dateutil[${PYTHON_USEDEP}] > dev-python/pycryptodome[${PYTHON_USEDEP}] > dev-python/future[${PYTHON_USEDEP}] Please sort this list. > postgres? ( dev-python/psycopg:2[${PYTHON_USEDEP}] )" > >#src_configure() { > # https://github.com/fish-face/quasselgrep/pull/15 ># sed -i 's/pycrypto/pycryptodome/g' "${S}"/setup.py || die "sed failed" >#} Again, this can be removed. And this kind of operation needs to happen in src_prepare rather than src_configure.
I forgot to mention IUSE="postgres" seems to have no function in the ebuild rather than pull a runtime dependency, it should be removed then and moved to 'optfeature'.
Created attachment 585774 [details] quasselgrep-0_p20190211.ebuild Thanks for the review. I think I covered all your advice.
Created attachment 585776 [details] metadata.xml Added upstream bug address to metadata.xml
Comment on attachment 585774 [details] quasselgrep-0_p20190211.ebuild >IUSE="sqlite" > >RDEPEND="sqlite? ( "dev-lang/python[sqlite]" ) With new eyes I believe this is wrong. Just remove the IUSE altogether and use PYTHON_REQ_USE in this ebuild. It needs to be called before inheriting distutils-r1. Test it please, if it works, I believe it's ready to be merged.
Created attachment 585972 [details] quasselgrep-0_p20190211.ebuild The ebuilld has been updated. Thanks for your help, and time with this. Signed-off-by: Scott Martin om@organizedmagnetism.com (DCO-1.1)
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ed40d3c4d27621fdca2bec1b36fd86f476b764cb commit ed40d3c4d27621fdca2bec1b36fd86f476b764cb Author: Scott Martin <om@organizedmagnetism.com> AuthorDate: 2019-08-07 16:02:49 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2019-08-07 16:06:02 +0000 net-irc/quasselgrep: bump to 0_p20190211 Signed-off-by: Scott Martin <om@organizedmagnetism.com> Closes: https://bugs.gentoo.org/659634 Signed-off-by: Joonas Niilola <juippis@gentoo.org> net-irc/quasselgrep/Manifest | 1 + net-irc/quasselgrep/quasselgrep-0_p20190211.ebuild | 35 ++++++++++++++++++++++ 2 files changed, 36 insertions(+)
Well that didnt quite go as planned, I cleaned the ebuild a bit. Didnt add metadata.xml yet, Ill maybe do it later. Next time please please please use github, pulling from bugzilla is hard and I couldve worked on 5 PRs using the time I used for this one.
