Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 659572 - net-misc/curl-7.60.0 installs libcurl.pc with openssl when ssl useflag is not set
Summary: net-misc/curl-7.60.0 installs libcurl.pc with openssl when ssl useflag is not...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Anthony Basile
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-29 07:08 UTC by Stephen Shkardoon
Modified: 2018-06-29 13:35 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
curl-7.60.0-r1 - fix broken libcurl.pc (curl-7.60.0-r1.ebuild,7.03 KB, text/plain)
2018-06-29 07:09 UTC, Stephen Shkardoon
Details
net-misc/curl: fix generated libcurl.pc when not using ssl (retain stable keywords) (0001-net-misc-curl-fix-generated-libcurl.pc-when-not-stable.patch,7.97 KB, patch)
2018-06-29 10:31 UTC, Stephen Shkardoon
Details | Diff
net-misc/curl: fix generated libcurl.pc when not using ssl (0001-net-misc-curl-fix-generated-libcurl.pc-when-not-usin.patch,7.99 KB, patch)
2018-06-29 10:32 UTC, Stephen Shkardoon
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen Shkardoon 2018-06-29 07:08:23 UTC
The ebuild for net-misc/curl-7.60.0 includes the following statement(s):

    if use curl_ssl_openssl; then
        libs+=( "-lssl" "-lcrypto" )
        priv+=( "openssl" )
    fi

curl_ssl_openssl is set in the default profile, but +ssl is not. This means if a user compiles net-misc/curl without SSL support, they'll still have libcurl.pc installed with openssl required. This breaks other packages that attempt to include curl through pkg-config.

I've attached a new revbump'd ebuild, but left the stable flags there, as this doesn't change the functionality of curl, only libcurl.pc.


Reproducible: Always

Steps to Reproduce:
1. Install net-misc/curl with the profile standard useflags (e.g. +curl_ssl_openssl, -ssl)
Actual Results:  
/usr/lib/pkgconfig/libcurl.pc includes openssl

Expected Results:  
/usr/lib/pkgconfig/libcurl.pc does not include openssl
Comment 1 Stephen Shkardoon 2018-06-29 07:09:50 UTC
Created attachment 537686 [details]
curl-7.60.0-r1 - fix broken libcurl.pc
Comment 2 Anthony Basile gentoo-dev 2018-06-29 09:43:07 UTC
(In reply to Stephen Shkardoon from comment #1)
> Created attachment 537686 [details]
> curl-7.60.0-r1 - fix broken libcurl.pc

Thanks, but can you give this to me as a patch preferably using git diff so that I can git proper attribution.  If not, I'll just try to mesh this as is.
Comment 3 Stephen Shkardoon 2018-06-29 10:31:55 UTC
Created attachment 537692 [details, diff]
net-misc/curl: fix generated libcurl.pc when not using ssl (retain stable keywords)

This patch retains the stable keywords
Comment 4 Stephen Shkardoon 2018-06-29 10:32:25 UTC
Created attachment 537694 [details, diff]
net-misc/curl: fix generated libcurl.pc when not using ssl

This version rekeywords everything to ~
Comment 5 Stephen Shkardoon 2018-06-29 10:33:34 UTC
I wasn't sure if that was the format you wanted (generated from `git format-patch`), but I guessed based on you asking for a version with proper attribution.

Otherwise, I've pushed a repoman'd commit to my Github too (https://github.com/ss23/gentoo/tree/net-misc/curl-pkg-config / https://github.com/ss23/gentoo/tree/net-misc/curl-pkg-config-stable)
Comment 6 Larry the Git Cow gentoo-dev 2018-06-29 13:35:50 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=99fbeebb2ceac399a075f8434be9769ff51a2d40

commit 99fbeebb2ceac399a075f8434be9769ff51a2d40
Author:     Stephen Shkardoon <ss23@ss23.geek.nz>
AuthorDate: 2018-06-29 10:25:37 +0000
Commit:     Anthony G. Basile <blueness@gentoo.org>
CommitDate: 2018-06-29 13:34:20 +0000

    net-misc/curl: fix generated libcurl.pc when not using ssl
    
    Closes: https://bugs.gentoo.org/659572
    Package-Manager: Portage-2.3.40, Repoman-2.3.9

 net-misc/curl/curl-7.60.0-r1.ebuild | 247 ++++++++++++++++++++++++++++++++++++
 1 file changed, 247 insertions(+)