Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 659386 - dev-cpp/ms-gsl-1.0.0 : [QA] One or more CMake variables were not used by the project:
Summary: dev-cpp/ms-gsl-1.0.0 : [QA] One or more CMake variables were not used by the ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal QA
Assignee: Jan Henke
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-27 17:02 UTC by Toralf Förster
Modified: 2018-07-07 13:57 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2018-06-27 17:02:36 UTC
QA: other
One or more CMake variables were not used by the project:
  FORCE_SYSTEM_CATCH

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.0-desktop-gnome_20180623-162007

  -------------------------------------------------------------------
Comment 1 Jan Henke 2018-07-06 19:29:23 UTC
Cannot reproduce. FORCE_SYSTEM_CATCH is patched in to allow using the system version of catch, it is also set to ON unconditionally in the ebuild.

Therefore I currently cannot see any problem. If you believe this problem does exist, please provide steps to reliable reproduce it.
Comment 2 Andreas Sturmlechner gentoo-dev 2018-07-07 07:29:35 UTC
Reproduced by simply running ebuild ms-gsl-1.0.0 configure.


-- Configuring done
-- Generating done
CMake Warning:
  Manually-specified variables were not used by the project:

    FORCE_SYSTEM_CATCH


-- Build files have been written to: /var/tmp/portage/dev-cpp/ms-gsl-1.0.0/work/ms-gsl-1.0.0_build
>>> Source configured.
Comment 3 Andreas Sturmlechner gentoo-dev 2018-07-07 07:31:50 UTC
Your variable is conditional to GSL_TEST=ON, plain simple, so the majority of setups gets a QA warning.
Comment 4 Jan Henke 2018-07-07 08:43:52 UTC
I see, that explains why I did not see the warning on my side, I always build with tests enabled. I will commit a fix for it.
Comment 5 Larry the Git Cow gentoo-dev 2018-07-07 13:57:59 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ade32fdab147393e09cc239e7cd5adc59a087c12

commit ade32fdab147393e09cc239e7cd5adc59a087c12
Author:     Jan Henke <Jan.Henke@taujhe.de>
AuthorDate: 2018-07-07 13:41:15 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-07-07 13:57:43 +0000

    dev-cpp/ms-gsl: Fix bug 659386
    
    Closes: https://bugs.gentoo.org/659386
    Package-Manager: Portage-2.3.40, Repoman-2.3.9
    Closes: https://github.com/gentoo/gentoo/pull/9082

 dev-cpp/ms-gsl/ms-gsl-1.0.0.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)