Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 659316 - app-emulation/qemu-guest-agent doesn't need x11-libs/pixman dependency
Summary: app-emulation/qemu-guest-agent doesn't need x11-libs/pixman dependency
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Matthias Maier
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-27 00:52 UTC by Paul B. Henson
Modified: 2018-06-29 05:35 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Paul B. Henson 2018-06-27 00:52:08 UTC
Reviewing configure:

if test "$want_tools" = "no" -a "$softmmu" = "no"; then
  pixman_cflags=
  pixman_libs=
elif $pkg_config --atleast-version=0.21.8 pixman-1 > /dev/null 2>&1; then
  pixman_cflags=$($pkg_config --cflags pixman-1)
  pixman_libs=$($pkg_config --libs pixman-1)

pixman is only required when --enable-tools is set; which results in:

if test "$want_tools" = "yes" ; then
  tools="qemu-img\$(EXESUF) qemu-io\$(EXESUF) $tools"
  if [ "$linux" = "yes" -o "$bsd" = "yes" -o "$solaris" = "yes" ] ; then
    tools="qemu-nbd\$(EXESUF) $tools"
  fi
  if [ "$ivshmem" = "yes" ]; then
    tools="ivshmem-client\$(EXESUF) ivshmem-server\$(EXESUF) $tools"
  fi
fi

the compilation of things that aren't even installed by the ebuild. The actual guest agent is controlled by --enable-guest-agent:

if [ "$guest_agent" != "no" ]; then
  if [ "$linux" = "yes" -o "$bsd" = "yes" -o "$solaris" = "yes" -o "$mingw32" = "yes" ] ; then
      tools="qemu-ga $tools"
      guest_agent=yes

which is completely independent of --enable-tools. The guest agent compiles and works fine without an X11 library and the dependency should be removed.
Comment 1 Larry the Git Cow gentoo-dev 2018-06-29 04:50:21 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=051ab2d0f0ab4d09848b9ace98a8ae10a9914d8f

commit 051ab2d0f0ab4d09848b9ace98a8ae10a9914d8f
Author:     Matthias Maier <tamiko@gentoo.org>
AuthorDate: 2018-06-29 04:30:52 +0000
Commit:     Matthias Maier <tamiko@gentoo.org>
CommitDate: 2018-06-29 04:30:52 +0000

    app-emulation/qemu-guest-agent: do not depend on pixman
    
    Closes: https://bugs.gentoo.org/659316
    Package-Manager: Portage-2.3.41, Repoman-2.3.9

 ...emu-guest-agent-2.12.0.ebuild => qemu-guest-agent-2.12.0-r1.ebuild} | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Comment 2 Paul B. Henson 2018-06-29 05:27:57 UTC
Oops, I see I didn’t explicitly mention that —disable-tools needs to be added to the configure parameters, sorry. —enable-tools is the default, without disabling it configure will complain it can’t find pixman. I looked at your diff and saw the dep was removed but configure args not updated; returning to the bug I see that’s my fault as I forgot to mention it :(. Sorry for the confusion and thanks for handling the bug report.
Comment 3 Larry the Git Cow gentoo-dev 2018-06-29 05:33:15 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4968b9aca32875f31e1f5c04748221ab1adb6b14

commit 4968b9aca32875f31e1f5c04748221ab1adb6b14
Author:     Matthias Maier <tamiko@gentoo.org>
AuthorDate: 2018-06-29 05:31:57 +0000
Commit:     Matthias Maier <tamiko@gentoo.org>
CommitDate: 2018-06-29 05:31:57 +0000

    app-emulation/qemu-guest-agent: disable tools
    
    We also have to disable tools configuration when compiling the guest
    agent.
    
    Bug: https://bugs.gentoo.org/659316
    Package-Manager: Portage-2.3.41, Repoman-2.3.9

 app-emulation/qemu-guest-agent/qemu-guest-agent-2.11.1.ebuild    | 1 +
 app-emulation/qemu-guest-agent/qemu-guest-agent-2.12.0-r1.ebuild | 1 +
 2 files changed, 2 insertions(+)
Comment 4 Matthias Maier gentoo-dev 2018-06-29 05:35:25 UTC
(In reply to Paul B. Henson from comment #2)
> returning to the bug I see that’s my fault as I forgot to mention it :(.

No worries. That's entirely my fault. Should be fixed now (this time checked without an already installed pixman...)