Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 659242 - sys-boot/grub-2.02-r1 doesn't work with newer XFS filesystems [patch available]
Summary: sys-boot/grub-2.02-r1 doesn't work with newer XFS filesystems [patch available]
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mike Gilbert
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-26 13:33 UTC by Guillaume Ceccarelli
Modified: 2018-06-26 14:45 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
grub patch for xfs sparse inode support (xfsv5_sparse_inodes.patch,964 bytes, patch)
2018-06-26 13:33 UTC, Guillaume Ceccarelli
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Guillaume Ceccarelli 2018-06-26 13:33:37 UTC
Created attachment 537282 [details, diff]
grub patch for xfs sparse inode support

grub 2.02 fails to recognize newly-created XFS filesystems, as xfsprogs from 4.16.0 and up creates XFS filesystems with sparse inodes by default, which aren't recognized properly by any released upstream grub version.

The relevant upstream bug is here: https://savannah.gnu.org/bugs/?48645
And the patch it contains is here: http://git.savannah.gnu.org/cgit/grub.git/commit/?id=cda0a857dd7a27cd5d621747464bfe71e8727fff

This patch also seems to have been applied by fedora according to https://src.fedoraproject.org/cgit/rpms/grub2.git/tree/0250-xfs-accept-filesystem-with-sparse-inodes.patch

I have tested this patch myself and haven't encountered any problem with it. I'm attaching it to this bug for easier reference.

I suggest for it to be added to the patchset applied on top of grub 2.02, and for a sys-boot/grub-2.02-r2 ebuild to be released with it accordingly.
Comment 1 Larry the Git Cow gentoo-dev 2018-06-26 14:45:22 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=74dfccb5ec0da32830673621abcce6e156177b83

commit 74dfccb5ec0da32830673621abcce6e156177b83
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2018-06-26 14:44:54 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2018-06-26 14:45:15 +0000

    sys-boot/grub: support XFS sparse inodes
    
    Closes: https://bugs.gentoo.org/659242
    Package-Manager: Portage-2.3.40_p15, Repoman-2.3.9_p247

 sys-boot/grub/files/2.02-xfs-sparse-inodes.patch |  60 +++++
 sys-boot/grub/grub-2.02-r2.ebuild                | 312 +++++++++++++++++++++++
 2 files changed, 372 insertions(+)