Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 658608 - net-misc/ntp-4.2.8_p11: ntpdate.service should have Wants=network-online.target
Summary: net-misc/ntp-4.2.8_p11: ntpdate.service should have Wants=network-online.target
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2018-06-20 19:54 UTC by Craig Andrews
Modified: 2019-08-27 18:50 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Craig Andrews gentoo-dev 2018-06-20 19:54:38 UTC 
/lib/systemd/system/ntpdate.service currently says:
Wants=time-sync.target

I believe that should be:
Wants=network-online.target time-sync.target

See https://www.freedesktop.org/wiki/Software/systemd/NetworkTarget/
Comment 1 Larry the Git Cow gentoo-dev 2019-08-27 18:50:36 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e4b4dea3d09eef699a51f915e96e53db6084b46b

commit e4b4dea3d09eef699a51f915e96e53db6084b46b
Author:     Craig Andrews <candrews@gentoo.org>
AuthorDate: 2019-08-27 18:30:25 +0000
Commit:     Craig Andrews <candrews@gentoo.org>
CommitDate: 2019-08-27 18:43:20 +0000

    net-misc/ntp: systemd service improvements
    
    systemd services Wants=network-online.target
    Remove explicit reference to NetworkManager,
      use generic network-online.target instead
    
    Closes: https://bugs.gentoo.org/658608
    Package-Manager: Portage-2.3.73, Repoman-2.3.17
    Signed-off-by: Craig Andrews <candrews@gentoo.org>

 net-misc/ntp/files/ntpdate.service-r2 |  14 ++++
 net-misc/ntp/files/sntp.service-r3    |  14 ++++
 net-misc/ntp/ntp-4.2.8_p13-r1.ebuild  | 146 ++++++++++++++++++++++++++++++++++
 3 files changed, 174 insertions(+)