Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 658600 - x11-base/xorg-server-1.20.0 needs to require mesa-18
Summary: x11-base/xorg-server-1.20.0 needs to require mesa-18
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-20 17:33 UTC by Andrew John Hughes
Modified: 2018-08-18 05:02 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew John Hughes 2018-06-20 17:33:06 UTC
/mnt/builder/portage.build/portage/x11-base/xorg-server-1.20.0/work/xorg-server-1.20.0/hw/xfree86/drivers/modesetting/drmmode_display.c: In function ‘get_modifiers_set’:
/mnt/builder/portage.build/portage/x11-base/xorg-server-1.20.0/work/xorg-server-1.20.0/hw/xfree86/drivers/modesetting/drmmode_display.c:171:21: error: implicit declaration of function ‘gbm_device_get_format_modifier_plane_count’; did you mean ‘gbm_device_is_format_supported’? [-Werror=implicit-function-declaration]
                     gbm_device_get_format_modifier_plane_count(drmmode->gbm,
                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                     gbm_device_is_format_supported

gbm_device_get_format_modifier_plane_count was only added to /usr/include/gbm.h in mesa-18. mesa-17, which I had installed for the above build, doesn't contain the function.
Comment 1 Matt Turner gentoo-dev 2018-06-20 21:23:37 UTC
It was added by commit https://gitlab.freedesktop.org/mesa/mesa/commit/8824141b8d48d9120ddbf542d6fb661046c41c62 which according to git tag --contains was first in mesa-17.3.0.

I believe there is a bug here, but I don't think it's due to an incorrectly versioned dependency.
Comment 2 Matt Turner gentoo-dev 2018-06-20 21:24:52 UTC
Hm, the current dependency is indeed out of date:

    >=media-libs/mesa-10.3.4-r1[egl,gbm]

Perhaps you had something older than mesa-17.3 installed?
Comment 3 Andrew John Hughes 2018-06-20 22:32:51 UTC
I know it was 17.x and the function was not present in gbm.h before I updated. I'm sorry, I don't recall the exact version, but I guess it was probably before 17.3 if that's when it was added. Thanks for finding the exact commit.

The point is that the 10.x is clearly wrong. The correct behaviour would have been for xorg-server to pull in the latest Mesa before attempting to build xorg-server. Instead, it tried to build using the installed version and failed.
Comment 4 Matt Turner gentoo-dev 2018-06-20 23:57:54 UTC
It's in your logs. Please provide the output of

> grep 'media-libs/mesa' /var/log/emerge.log | tail
Comment 5 Matt Turner gentoo-dev 2018-08-14 20:37:15 UTC
(In reply to Matt Turner from comment #4)
> It's in your logs. Please provide the output of
> 
> > grep 'media-libs/mesa' /var/log/emerge.log | tail

So, I shouldn't expect to hear back from you I'm guessing?
Comment 6 Larry the Git Cow gentoo-dev 2018-08-18 05:02:04 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a2c1cc004556090f8bd6463a7b5b6136e7067b71

commit a2c1cc004556090f8bd6463a7b5b6136e7067b71
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2018-08-18 05:01:21 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2018-08-18 05:01:21 +0000

    x11-base/xorg-server: Depend on >=media-libs/mesa-18
    
    Closes: https://bugs.gentoo.org/658600

 x11-base/xorg-server/xorg-server-1.20.1.ebuild | 4 ++--
 x11-base/xorg-server/xorg-server-9999.ebuild   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)