Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 658472 - x11-terms/terminator with dbus USE flag enabled should depend on dev-python/dbus-python
Summary: x11-terms/terminator with dbus USE flag enabled should depend on dev-python/d...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: Alexey
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2018-06-19 09:37 UTC by El Goretto
Modified: 2020-06-04 12:09 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description El Goretto 2018-06-19 09:37:17 UTC
As stated by `man terminator_config`:

global_config
dbus: Control  whether or not Terminator will load its DBus server. [...] If  this configuration  item is set to False, or the python dbus module is unavailable, running Terminator multiple times will run a separate Terminator process for each invocation.

I can confirm that after emerging dev-python/dbus-python, enabling the "dbus server" option in Terminator works as intended, and only only one Terminator process is spawned.

For now, in the terminator ebuild: dbus? ( sys-apps/dbus )
I guess it should be: 
dbus? ( 
   sys-apps/dbus 
   dev-python/dbus-python
)


Regards,
elgo
Comment 1 Larry the Git Cow gentoo-dev 2020-06-04 12:09:20 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6dac8fb429770efb97e04f09415b93ba70b97ea7

commit 6dac8fb429770efb97e04f09415b93ba70b97ea7
Author:     Alexey Sokolov <sokolov@google.com>
AuthorDate: 2020-05-16 00:45:45 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-06-04 12:09:03 +0000

    x11-terms/terminator: fix dbus dependency
    
    I removed sys-apps/dbus because dev-python/dbus-python already depends
    on it anyway.
    
    Closes: https://bugs.gentoo.org/658472
    Package-Manager: Portage-2.3.99, Repoman-2.3.22
    Signed-off-by: Alexey Sokolov <sokolov@google.com>
    Closes: https://github.com/gentoo/gentoo/pull/15815
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 x11-terms/terminator/terminator-1.92-r1.ebuild | 60 ++++++++++++++++++++++++++
 1 file changed, 60 insertions(+)