Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 658446 - dev-python/requests has missed upper version requirement on `urllib3`
Summary: dev-python/requests has missed upper version requirement on `urllib3`
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 658316
  Show dependency tree
 
Reported: 2018-06-19 00:14 UTC by Alex Turbov
Modified: 2018-06-24 16:39 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Turbov 2018-06-19 00:14:37 UTC
https://github.com/requests/requests/blob/883caaf145fbe93bd0d208a6b864de9146087312/setup.py#L54

having =urllib3-1.23 installed makes all software depended on `requests` fail w/ the constraint violation error

Reproducible: Always
Comment 1 Alex Turbov 2018-06-19 00:17:03 UTC
... forget to mention, I had requests 2.18.4 installed, which is (according to github release histlry) had `urllib3` < 1.23 dependency.
Comment 2 Daniel M. Weeks 2018-06-19 19:56:58 UTC
I am seeing the following with dev-python/requests-2.18.4, dev-python/chardet-3.0.4, and dev-python/urllib3-1.23:

/usr/lib64/python3.5/site-packages/requests/__init__.py:80: RequestsDependencyWarning: urllib3 (1.23) or chardet (3.0.4) doesn't match a supported version!
  RequestsDependencyWarning)
Comment 3 Sebastian Pipping gentoo-dev 2018-06-24 16:28:36 UTC
Ouch!


$ docker-compose up -d
[..]
pkg_resources.DistributionNotFound: The 'urllib3<1.23,>=1.21.1' distribution was not found and is required by requests


(with requests 2.18.4)

I'll try a fix myself in a minute.
Comment 4 Larry the Git Cow gentoo-dev 2018-06-24 16:37:18 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e3463a845cf8f29372a33fae566c6255cd60aa75

commit e3463a845cf8f29372a33fae566c6255cd60aa75
Author:     Sebastian Pipping <sping@gentoo.org>
AuthorDate: 2018-06-24 16:35:06 +0000
Commit:     Sebastian Pipping <sping@gentoo.org>
CommitDate: 2018-06-24 16:35:06 +0000

    dev-python/requests: Fix urllib3 dependency
    
    Bug: https://bugs.gentoo.org/658446
    Package-Manager: Portage-2.3.40, Repoman-2.3.9

 dev-python/requests/requests-2.18.2-r1.ebuild | 4 ++--
 dev-python/requests/requests-2.18.4.ebuild    | 2 +-
 dev-python/requests/requests-2.19.1.ebuild    | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)
Comment 5 Sebastian Pipping gentoo-dev 2018-06-24 16:39:18 UTC
I think we're good now, please re-open if needed.