Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 658390 - net-p2p/rtorrent-0.9.7: error: #error "SysV or X/Open-compatible Curses header file required"
Summary: net-p2p/rtorrent-0.9.7: error: #error "SysV or X/Open-compatible Curses heade...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Stephen Shkardoon
URL: https://github.com/rakshasa/rtorrent/...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-18 10:40 UTC by Michał Górny
Modified: 2018-06-19 05:38 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
net-p2p:rtorrent-0.9.7:20180618-100805.log (net-p2p:rtorrent-0.9.7:20180618-100805.log,422.69 KB, text/plain)
2018-06-18 10:40 UTC, Michał Górny
Details
config.log (config.log,74.46 KB, text/plain)
2018-06-18 10:41 UTC, Michał Górny
Details
rtorrent-0.9.7-r1 (rtorrent-0.9.7-r1.ebuild,1.86 KB, text/plain)
2018-06-18 20:35 UTC, jeremy mills
Details
rtorrent-0.9.7-tinfo.patch (rtorrent-0.9.7-tinfo.patch,1.42 KB, patch)
2018-06-18 20:37 UTC, jeremy mills
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-06-18 10:40:59 UTC
Created attachment 536172 [details]
net-p2p:rtorrent-0.9.7:20180618-100805.log

In file included from canvas.h:43:0,
                 from window.h:43,
                 from frame.cc:46:
attributes.h:54:2: error: #error "SysV or X/Open-compatible Curses header file required"
 #error "SysV or X/Open-compatible Curses header file required"
  ^~~~~

Followed by a lot of errors.  Looks like configure checks for curses headers are misfiring.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-06-18 10:41:36 UTC
Created attachment 536174 [details]
config.log
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-06-18 10:42:18 UTC
Portage[mgorny] 2.3.36.1 (python 3.6.5-final-0, default/linux/amd64/17.1/desktop, gcc-6.4.0, glibc-2.27-r4, 4.17.0-pf2-mgorny-amd64+ x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-4.17.0-pf2-mgorny-amd64+-x86_64-AMD_Athlon-tm-_64_X2_Dual_Core_Processor_3800+-with-gentoo-2.6
Timestamp of repository gentoo: Mon, 18 Jun 2018 09:46:13 +0000
Head commit of repository gentoo: cd2bb11a97ad7ea7de4afe7511fff63ab3127a3f

sh bash 4.4_p23
ld GNU ld (Gentoo 2.30 p3) 2.30.0
distcc 3.2rc1 x86_64-pc-linux-gnu [enabled]
ccache version 3.3.4 [disabled]
app-shells/bash:          4.4_p23::gentoo
dev-java/java-config:     2.2.0-r4::gentoo
dev-lang/perl:            5.26.2::gentoo
dev-lang/python:          2.7.15::gentoo, 3.4.8-r1::gentoo, 3.5.5-r1::gentoo, 3.6.5-r1::gentoo
dev-util/ccache:          3.3.4-r1::gentoo
dev-util/cmake:           3.11.4::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.6::gentoo
sys-apps/sandbox:         2.13::gentoo
sys-devel/autoconf:       2.13::gentoo, 2.69-r4::gentoo
sys-devel/automake:       1.11.6-r3::gentoo, 1.14.1-r2::gentoo, 1.15.1-r2::gentoo, 1.16.1-r1::gentoo
sys-devel/binutils:       2.30-r3::gentoo
sys-devel/gcc:            6.4.0-r1::gentoo
sys-devel/gcc-config:     1.9.1::gentoo
sys-devel/libtool:        2.4.6-r5::gentoo
sys-devel/make:           4.2.1-r3::gentoo
sys-kernel/linux-headers: 4.16-r1::gentoo (virtual/os-headers)
sys-libs/glibc:           2.27-r4::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/gentoo.git
    priority: -1000
    sync-git-verify-commit-signature: true

python
    location: /home/mgorny/git/python-repo
    masters: gentoo

mgorny
    location: /home/mgorny/git/mgorny-repo
    masters: gentoo
    priority: 10000

Installed sets: @mg_depends_cb_agent, @mg_depends_qaweb
ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="gd dom4j ZSH rwpng SVFL CAOSL Ispell AMPAS mpich2 LPPL-1.3 IDPL mapm-4.9.5 Snd xbatt the-Click-license regexp-UofT JNIC Subversion CMake LLVM-Grant qmail-nelson yuuji Time-Format Emacs Openwall torque-2.5 wxWinLL-3.1 iASL docbook rdisc Princeton mm imagemagick LPPL-1.3b scanlogd File-MMagic Old-MIT otter Toyoda ACE alternate perforce SNIA freetts ErlPL-1.1 BZIP2 shrimp photopc keynote BSD-with-attribution w3m freemarker LambdaMOO psutils pngnq rc libpng ipx-utils bufexplorer.vim TeX-other-free tcp_wrappers_license Xdebug totd xtrs ipadic xvt BEER-WARE NCSA-HDF Mini-XML PCRE Time-modules gsm canfep libtiff CeCILL-C htmlc RSA SMAIL boehm-gc FLTK YaTeX UCAR-Unidata Crypt-IDEA CDDL-Schily buddy FastCGI FLEX symlinks Mail-Sendmail JDOM matplotlib NEWLIB tm-align Flashpix bea.ri.jsr173 PHP-2.02 ngrep XC x2x Allegro flexmock tcltk pngcrush DES repoze FVWM TeX libmng Sendmail feh minpack lsof MIT-with-advertising xboing CPL-0.5 CRACKLIB LIBGLOSS Info-ZIP JasPer2.0 HTML-Tidy SSLeay inner-net tablelist telegram URT JOVE BSD-1 ElementTree VTK openafs-krb5-a netcat icu Sendmail-Open-Source eGenixPublic-1.1 CPAL-1.0 EUPL-1.1 NPL-1.1 EPL-2.0 PHP-3.01 CDDL MPL-1.1 Zend-2.0 CPL-1.0 EPL-1.0 APSL-2 OSL-1.1 OSL-2.1 libgcc IJG PYTHON GPL-2+ LGPL-2+ vim Unlicense public-domain LGPL-3-with-linking-exception GPL-3+-with-opencl-openssl-exception ISC GPL-3+-with-cuda-openssl-exception BSD GPL-3+ LGPL-2 LGPL-2-with-linking-exception libstdc++ PSF-2 GPL-3 Boost-1.0 AGPL-3+ ECL-2.0 GPL-3+-with-opencl-exception LGPL-2.1 LGPL-2.1-with-linking-exception MIT Sleepycat LGPL-3+ LGPL-2.1+ unicode WTFPL-2 PSF-2.3 CeCILL-2 GPL-2-with-MySQL-FLOSS-exception SGI-B-2.0 ZPL GPL-2-with-exceptions AGPL-3 Clarified-Artistic tanuki-community ZLIB Ruby UoI-NCSA PSF-2.2 gcc-runtime-library-exception-3.1 GPL-2 FTL BSD-2 Clear-BSD LGPL-3 Apache-2.0 qwt GPL-1 GPL-3-with-openssl-exception W3C OPENLDAP PSF-2.4 metapackage GPL-3+-with-cuda-exception GPL-3-with-font-exception Ruby-BSD CC0-1.0 MPL-2.0 GPL-2-with-classpath-exception GPL-2-with-font-exception GPL-2+-with-openssl-exception HPND Nokia-Qt-LGPL-Exception-1.1 Artistic-2 GPL-2-with-linking-exception UPX-exception Transmission-OpenSSL-exception GPL-1+ QPL-1.0 CNRI AFL-2.1 BSD-4 Apache-1.1 QPL LPPL-1.2 gnuplot Ms-PL MPL-1.0 IBM openssl OSL-2.0 Apache-1.0 AFL-3.0 GPL-2+ LGPL-2+ CPAL-1.0 Artistic POSTGRESQL IPAfont ISC NOSA BSD EUPL-1.1 GPL-3+ PSF-2 EPL-2.0 GPL-3 Boost-1.0 AGPL-3+ PHP-3.01 ECL-2.0 LGPL-2.1 CDDL MIT Sleepycat LGPL-3+ LGPL-2.1+ MPL-1.1 OFL-1.1 CPL-1.0 EPL-1.0 APL-1.0 APSL-2 OSL-2.1 ZPL AGPL-3 ZLIB Watcom-1.0 UoI-NCSA CNRI wxWinLL-3 GPL-2 Apache-1.1 QPL Ms-PL BSD-2 LGPL-3 nethack MPL-1.0 Apache-2.0 IBM W3C MPL-2.0 AFL-3.0 HPND Artistic-2 PHP-3 LPPL-1.3c GPL-1+ GPL-2+ CC-BY-SA-2.5 OFL IPAfont GPL-3+ FDL-1.2 GPL-3 OFL-1.1 FDL-1.1 FDL-1.3+ CC-BY-2.0 OPL FDL-1.3 CC-BY-SA-4.0 FDL-1.1+ FreeArt CC-BY-SA-3.0 CC-BY-4.0 GPL-2 Arphic GPL-1 CC-BY-2.5 FDL-1.2+ CC-BY-SA-2.0 CC-BY-3.0 GPL-1+ LDP-1 wxWinFDL-3 LDP-1a man-pages-posix man-pages-posix-2013 man-pages mplus-fonts Unicode_Fonts_for_Ancient_Scripts CC-PD CC-SA-1.0 BitstreamVera myspell-en_CA-KevinAtkinson Texinfo-manual UbuntuFontLicense-1.0 vlgothic CC-BY-SA-1.0 MaxMind2 quake1-textures -AGPL-3 -AGPL-3+"
CBUILD="x86_64-pc-linux-gnu"
CC="x86_64-pc-linux-gnu-gcc-6.4.0"
CFLAGS="-march=k8-sse3 -mcx16 -msahf --param l1-cache-size=64 --param l1-cache-line-size=64 --param l2-cache-size=512 -O2 -pipe -frecord-gcc-switches"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXX="x86_64-pc-linux-gnu-g++-6.4.0"
CXXFLAGS="-march=k8-sse3 -mcx16 -msahf --param l1-cache-size=64 --param l1-cache-line-size=64 --param l2-cache-size=512 -O2 -pipe -frecord-gcc-switches"
DISTDIR="/srv/nfs/common/distfiles"
EMERGE_DEFAULT_OPTS="--with-bdeps y --ask --keep-going --quiet-build=n --dynamic-deps=n"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-march=k8-sse3 -mcx16 -msahf --param l1-cache-size=64 --param l1-cache-line-size=64 --param l2-cache-size=512 -O2 -pipe -frecord-gcc-switches"
FEATURES="assume-digests binpkg-logs binpkg-multi-instance buildpkg cgroup collision-protect config-protect-if-modified distcc distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict news parallel-fetch preserve-libs protect-owned sandbox sfperms sign strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync webrsync-gpg"
FFLAGS="-march=k8-sse3 -mcx16 -msahf --param l1-cache-size=64 --param l1-cache-line-size=64 --param l2-cache-size=512 -O2 -pipe -frecord-gcc-switches"
GENTOO_MIRRORS="http://mirror.netcologne.de/gentoo/ http://gentoo.mirror.web4u.cz/ http://ftp.snt.utwente.nl/pub/os/linux/gentoo http://gd.tuwien.ac.at/opsys/linux/gentoo/ http://ftp.vectranet.pl/gentoo/ http://ftp.fi.muni.cz/pub/linux/gentoo/"
INSTALL_MASK="/test /usr/share/locale -/usr/share/locale/pl"
LANG="pl_PL.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu"
MAKEOPTS="-j12"
PKGDIR="/srv/nfs/common/packages/athlon64"
PORTAGE_COMPRESS="lzip"
PORTAGE_COMPRESS_FLAGS="-9"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --times --compress --force --whole-file --delete --stats --timeout=45 --exclude=/distfiles --exclude=/packages --exclude=/local --exclude=CVS --exclude=/metadata/cache --omit-dir-times"
PORTAGE_TMPDIR="/tmp"
USE="3dnow 3dnowext X a52 aac acl adns aio alsa amd64 ayatana bash-completion bluetooth branding btrfs bzip2 cairo caps cdda cdr cli crypt cups curl cxx dbus djvu dri dts dvb dvd dvdr egl emboss exif fftw flac fontconfig fortran gd gif glamor gmp gnuplot gnutls gphoto2 gstreamer gtk iconv idn imagemagick ipv6 jpeg jpeg2k kate latex lcms libass libatomic liblockfile libnotify libproxy libsamplerate libsecret libtiger libtirpc linguas_pl lz4 lzma lzo mad mmap mmxext mng modules mp3 mp4 mpeg mtp multilib ncurses nls nptl ogg openal opencl opengl openmp openvg opus osmesa pam pango pch pcre pcre-jit pdf plotutils png policykit postscript ppds pulseaudio qt3support qt5 readline sctp sdl seccomp slang smp sndfile speex spell sse3 ssl startup-notification svg systemd t1lib tcpd threads tiff truetype udev udisks unicode upower usb v4l2 vaapi vhosts vim-syntax vorbis wavpack wayland webp wmf wxwidgets x264 xattr xcb xft xml xpm xv xvid xvmc zeroconf zlib" ABI_X86="64 32" ALSA_CARDS="hda-intel emu10k1 mpu401 pcsp virmidi" APACHE2_MODULES="socache_shmcb unixd actions alias deflate filter mime mime_magic negotiation rewrite" CALLIGRA_FEATURES="karbon plan sheets stage words" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext sse sse2 3dnow 3dnowext sse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" L10N="pl" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LIRC_DEVICES="serial" LLVM_TARGETS="*" NGINX_MODULES_HTTP="gzip limit_conn limit_req rewrite spdy uwsgi" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6 php7-0" POSTGRES_TARGETS="postgres9_5 postgres10" PYTHON_SINGLE_TARGET="python3_5" PYTHON_TARGETS="python2_7 python3_5 jython2_7 pypy pypy3 python3_4 python3_6" QEMU_SOFTMMU_TARGETS="aarch64 arm i386 ppc ppc64 ppc64abi32 x86_64" QEMU_USER_TARGETS="aarch64 arm ppc ppc64" RUBY_TARGETS="ruby23 *" SANE_BACKENDS="artec_eplus48u" USERLAND="GNU" VIDEO_CARDS="nouveau radeon vesa r600 s3" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, LC_ALL, LINGUAS, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_RSYNC_EXTRA_OPTS

=================================================================
                        Package Settings
=================================================================

sys-libs/ncurses-6.1-r2::gentoo was built with the following:
USE="cxx debug threads tinfo unicode -ada -doc -gpm -minimal -profile -static-libs -test -trace" ABI_X86="32 64 -x32"
Comment 3 jeremy mills 2018-06-18 19:17:55 UTC
I can confirm this. Looking at the logs it looks like its complaining about tinfo not being properly linked in ncurses. maybe we still need the tinfo and ncurses patches. They are absent from the 0.9.7 ebuild. ill try readding them in my local overlay and report back.

on a side note it does compile properly with sys-libs/ncurses USE=-tinfo
Comment 4 Stephen Shkardoon 2018-06-18 19:19:50 UTC
https://bugs.gentoo.org/614984 - This is the same kind of bug in a different package if anyone wants to take a stab at resolving this before I get a chance.
Comment 5 jeremy mills 2018-06-18 20:33:56 UTC
Updated ebuild and new tinfo patch. Attached. Please look over them and test them. Im not that knowlegeable in ebuilds and patches and such so this might not have been done correctly. the 0.9.4-tinfo patch wouldnt apply so i just manually added the lines to configure.ac. then diffed it to get the patch. some lines were different so the original patch wouldnt apply. my patch just applies the same thing as the old tinfo patch...but in the proper locations for the configure.ac. if that makes sense.
Comment 6 jeremy mills 2018-06-18 20:35:01 UTC
Created attachment 536298 [details]
rtorrent-0.9.7-r1
Comment 7 jeremy mills 2018-06-18 20:36:00 UTC
Comment on attachment 536298 [details]
rtorrent-0.9.7-r1

revbump for new tinfo patch
Comment 8 jeremy mills 2018-06-18 20:37:09 UTC
Created attachment 536300 [details, diff]
rtorrent-0.9.7-tinfo.patch

new tinfo patch for 0.9.7
Comment 9 jeremy mills 2018-06-18 21:16:36 UTC
(In reply to Stephen Shkardoon from comment #4)
> https://bugs.gentoo.org/614984 - This is the same kind of bug in a different
> package if anyone wants to take a stab at resolving this before I get a
> chance.

try out the files i (patch and revbumped ebuild) i just attached to that bug. i went woth the latest stable keyworded build of varnish. but can easily make patches for any others im sure.
Comment 10 Stephen Shkardoon 2018-06-18 23:51:47 UTC
(In reply to jeremy mills from comment #9)
> try out the files i (patch and revbumped ebuild) i just attached to that
> bug. i went woth the latest stable keyworded build of varnish. but can
> easily make patches for any others im sure.

Thanks! I've modified the ebuild slightly to use PATCHES and avoid a revbump and submitted a pull request which should be merged shortly.
Comment 11 jeremy mills 2018-06-19 00:36:45 UTC
Your welcome. It would be nice to solve this system-wide without the need to patch every problem ebuild. But thats way over my head. Without the old tinfo patch i wouldnt have known where to begin. This should fix rtorrent and varnish in future versions too. unless the configure.ac file changes in a way that makes that patch fail. In which case all we should have to do is add them lines in the proper places and diff it to get our new patch. Thats what happened here. In the case of varnish everything was LIBS="${save_libs}". so i just picked a random spot and it happened to work the first time. I didnt check runtime though just that it would build. So hopefully there isnt any runtime issues. Anyways as long as theya re fixed thats all that matters. I might not understand exactly how but fixed is still fixed.
Comment 12 Larry the Git Cow gentoo-dev 2018-06-19 05:38:41 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e9423224749658cd38c46397c046ec89afd57d7d

commit e9423224749658cd38c46397c046ec89afd57d7d
Author:     Stephen Shkardoon <ss23@ss23.geek.nz>
AuthorDate: 2018-06-18 23:46:37 +0000
Commit:     Jason Zaman <perfinion@gentoo.org>
CommitDate: 2018-06-19 05:37:49 +0000

    net-p2p/rtorrent: resolve ncurses compile failure
    
    Adds a patch to ensure tinfo is correctly linked.
    This only occurs when ncurses is built with the "tinfo" useflag.
    Closes: https://bugs.gentoo.org/658390
    Package-Manager: Portage-2.3.40, Repoman-2.3.9

 net-p2p/rtorrent/files/rtorrent-0.9.7-tinfo.patch | 31 +++++++++++++++++++++++
 net-p2p/rtorrent/rtorrent-0.9.7.ebuild            |  4 +++
 2 files changed, 35 insertions(+)