Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 658316 - dev-python/requests-2.18.4 depends on <urllib3-1.23 (was: dev-util/cmake-3.12.0_rc1 w/ USE=doc: can't run sphinx due to python deps error)
Summary: dev-python/requests-2.18.4 depends on <urllib3-1.23 (was: dev-util/cmake-3.12...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on: 658446
Blocks:
  Show dependency tree
 
Reported: 2018-06-17 18:18 UTC by Alex Turbov
Modified: 2018-07-10 19:17 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Turbov 2018-06-17 18:18:50 UTC
Traceback (most recent call last):
  File "/usr/lib64/python3.6/site-packages/pkg_resources/__init__.py", line 666, in _build_master
    ws.require(__requires__)
  File "/usr/lib64/python3.6/site-packages/pkg_resources/__init__.py", line 984, in require
    needed = self.resolve(parse_requirements(requirements))
  File "/usr/lib64/python3.6/site-packages/pkg_resources/__init__.py", line 875, in resolve
    raise VersionConflict(dist, req).with_context(dependent_req)
pkg_resources.ContextualVersionConflict: (urllib3 1.23 (/usr/lib64/python3.6/site-packages), Requirement.parse('urllib3<1.23,>=1.21.1'), {'requests'})

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/python-exec/python3.6/sphinx-build", line 6, in <module>
    from pkg_resources import load_entry_point
  File "/usr/lib64/python3.6/site-packages/pkg_resources/__init__.py", line 3147, in <module>
    @_call_aside
  File "/usr/lib64/python3.6/site-packages/pkg_resources/__init__.py", line 3131, in _call_aside
    f(*args, **kwargs)
  File "/usr/lib64/python3.6/site-packages/pkg_resources/__init__.py", line 3160, in _initialize_master_working_set
    working_set = WorkingSet._build_master()
  File "/usr/lib64/python3.6/site-packages/pkg_resources/__init__.py", line 668, in _build_master
    return cls._build_from_requirements(__requires__)
  File "/usr/lib64/python3.6/site-packages/pkg_resources/__init__.py", line 681, in _build_from_requirements
    dists = ws.resolve(reqs, Environment())
  File "/usr/lib64/python3.6/site-packages/pkg_resources/__init__.py", line 870, in resolve
    raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'urllib3<1.23,>=1.21.1' distribution was not found and is required by requests

Reproducible: Always
Comment 1 Alex Turbov 2018-06-17 18:20:38 UTC
I've got `dev-python/requests-2.18.4` and `dev-python/urllib3-1.23` installed.
It looks like ebuild for `dev-python/requests` have missed `!>dev-python/urllib3-1.23` constraint
Comment 2 Andreas Sturmlechner gentoo-dev 2018-07-08 07:46:37 UTC
$ grep -C 3 urllib3 requests-2.18.4/setup.py 
requires = [
    'chardet>=3.0.2,<3.1.0',
    'idna>=2.5,<2.7',
    'urllib3>=1.21.1,<1.23',
    'certifi>=2017.4.17'

]


Not a cmake problem. Looks like e3463a84 should have also covered 2.18.4.
Comment 3 Sebastian Pipping gentoo-dev 2018-07-08 10:52:47 UTC
(In reply to Andreas Sturmlechner from comment #2)
> $ grep -C 3 urllib3 requests-2.18.4/setup.py 
> requires = [
>     'chardet>=3.0.2,<3.1.0',
>     'idna>=2.5,<2.7',
>     'urllib3>=1.21.1,<1.23',
>     'certifi>=2017.4.17'
> 
> ]
> 
> 
> Not a cmake problem. Looks like e3463a84 should have also covered 2.18.4.

e3463a84 does cover 2.18.4:


# git show e3463a84 | lsdiff --strip 1
dev-python/requests/requests-2.18.2-r1.ebuild
dev-python/requests/requests-2.18.4.ebuild
dev-python/requests/requests-2.19.1.ebuild

# fgrep urllib dev-python/requests/requests-2.18.4.ebuild
        <dev-python/urllib3-1.23[${PYTHON_USEDEP}]


To be honest I don't understand the problem in this very bug, yet.
Comment 4 Andreas Sturmlechner gentoo-dev 2018-07-08 17:16:29 UTC
(In reply to Sebastian Pipping from comment #3)
> To be honest I don't understand the problem in this very bug, yet.

Dependency change without version bump, which means the reporter has had 2.18.4 installed before your change.
Comment 5 Sebastian Pipping gentoo-dev 2018-07-08 18:07:29 UTC
(In reply to Andreas Sturmlechner from comment #4)
> Dependency change without version bump, which means the reporter has had
> 2.18.4 installed before your change.

I see, sorry.  What's the right approach here for a stable ebuild: Adding r1 as unstable or adding r1 as stable?  Former would not reach users of stable, second seems to bypass arch teams and will not be liked by repoman afair.

How do we proceed?
Comment 6 Andreas Sturmlechner gentoo-dev 2018-07-09 20:25:33 UTC
Bump -r1 as stable, as you are not doing anything else than correcting a dependency to fix stable, no other change that could possibly affect users.
Comment 7 Larry the Git Cow gentoo-dev 2018-07-09 21:22:08 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=71c61035f7ef25a095b02d462c86de22f61285b0

commit 71c61035f7ef25a095b02d462c86de22f61285b0
Author:     Sebastian Pipping <sping@gentoo.org>
AuthorDate: 2018-07-09 21:20:20 +0000
Commit:     Sebastian Pipping <sping@gentoo.org>
CommitDate: 2018-07-09 21:21:58 +0000

    dev-python/requests: Revbump for RDEPEND changes
    
    Follow-up to e3463a845cf8f29372a33fae566c6255cd60aa75 as advised
    Bug: https://bugs.gentoo.org/658316
    Package-Manager: Portage-2.3.40, Repoman-2.3.9
    RepoMan-Options: --force

 .../requests/{requests-2.18.2-r1.ebuild => requests-2.18.2-r2.ebuild}     | 0
 dev-python/requests/{requests-2.18.4.ebuild => requests-2.18.4-r1.ebuild} | 0
 dev-python/requests/{requests-2.19.1.ebuild => requests-2.19.1-r1.ebuild} | 0
 3 files changed, 0 insertions(+), 0 deletions(-)
Comment 8 Sebastian Pipping gentoo-dev 2018-07-09 21:23:44 UTC
(In reply to Andreas Sturmlechner from comment #6)
> Bump -r1 as stable, as you are not doing anything else than correcting a
> dependency to fix stable, no other change that could possibly affect users.

I hope the commit above looks close to what you had in mind.

How shall we proceed?
Comment 9 Andreas Sturmlechner gentoo-dev 2018-07-10 08:21:55 UTC
Well, this bug then can be considered fixed.
Comment 10 Sebastian Pipping gentoo-dev 2018-07-10 19:17:00 UTC
(In reply to Andreas Sturmlechner from comment #9)
> Well, this bug then can be considered fixed.

Excellent, thanks for your support.