Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 658164 - app-crypt/gnupg-2.2.8 depends on virtual/mta, again
Summary: app-crypt/gnupg-2.2.8 depends on virtual/mta, again
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Kristian Fiskerstrand (RETIRED)
URL: https://lists.gnupg.org/pipermail/gnu...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-15 10:07 UTC by Stefan Schmid
Modified: 2018-06-20 21:51 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
gnupg-2.2.8-r1.patch (gnupg-2.2.8-r1.patch,1.05 KB, patch)
2018-06-18 14:27 UTC, Scall
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Schmid 2018-06-15 10:07:33 UTC
The new Stable ebuild for "app-crypt/gnupg-2.2.8" agains depend on "virtual/mta".
Why should it? GnuPG does not need a mailer.

see Bug 382415
Comment 1 Scall 2018-06-15 12:05:07 UTC
It should at least be made optional via the "mta" USE flag:

mta? ( virtual/mta )
Comment 2 Gino McCarty 2018-06-15 22:17:28 UTC
(In reply to Scall from comment #1)
> It should at least be made optional via the "mta" USE flag:
> 
> mta? ( virtual/mta )

appears that's the solution that was implemented in Bug 382415 not sure how/why it got dropped here.
Comment 3 Alon Bar-Lev (RETIRED) gentoo-dev 2018-06-16 19:16:39 UTC
see bug#648606
Comment 4 Stefan Schmid 2018-06-18 05:32:02 UTC
I can build and use Version 2.2.8 without a sendmail binary.
Comment 5 Scall 2018-06-18 14:27:53 UTC
Created attachment 536182 [details, diff]
gnupg-2.2.8-r1.patch
Comment 6 Scall 2018-06-18 14:29:17 UTC
Also, the sendmail check/support can be removed with "--without-mailprog".

Proposed patch attached.
Comment 7 Alon Bar-Lev (RETIRED) gentoo-dev 2018-06-18 16:24:57 UTC
(In reply to Scall from comment #6)
> Also, the sendmail check/support can be removed with "--without-mailprog".
> 
> Proposed patch attached.

actually this is the right solution as I do not see any place that actually use the result of the autoconf SENDMAIL variable.
Comment 8 Kristian Fiskerstrand (RETIRED) gentoo-dev 2018-06-18 16:30:29 UTC
(In reply to Alon Bar-Lev from comment #7)
> (In reply to Scall from comment #6)
> > Also, the sendmail check/support can be removed with "--without-mailprog".
> > 
> > Proposed patch attached.
> 
> actually this is the right solution as I do not see any place that actually
> use the result of the autoconf SENDMAIL variable.

I'd tend to agree on just disabling it; that said, the use is wks client that is enabled by default, see e.g man gpg-wks-client's --send . I haven't seen the latest updates on what MUAs are doing for WKS support, but most are presumably setting up their own interface rather than relying on gnupg for it, will figure out more on this on next summit.
Comment 9 Alon Bar-Lev (RETIRED) gentoo-dev 2018-06-18 16:34:18 UTC
Removed.
I will send upstream a patch to remove this unused check.
Comment 10 Kristian Fiskerstrand (RETIRED) gentoo-dev 2018-06-19 08:05:57 UTC
wks: Take name of sendmail from configure.

* configure.ac (NAME_OF_SENDMAIL): New ac_define.
* tools/send-mail.c (run_sendmail): Use it.
--

We used to ac_subst the SENDMAIL in the old keyserver via mail script.
We cab reuse this to avoid a fixed name for sendmail in the
send-mail.c helper.


https://git.gnupg.org/cgi-bin/gitweb.cgi?p=gnupg.git;a=commit;h=08147f8bbdca40c98c2a094fa48fab15b8339c80
Comment 11 Alon Bar-Lev (RETIRED) gentoo-dev 2018-06-19 08:15:47 UTC
Reverting as gpg-wks-client is not optional.
Do you think that it will be accepted as optional if I send to upstream.
Comment 12 Larry the Git Cow gentoo-dev 2018-06-19 08:21:10 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=256c75221fb978ddaa17c69cfa453050d941b9bd

commit 256c75221fb978ddaa17c69cfa453050d941b9bd
Author:     Alon Bar-Lev <alonbl@gentoo.org>
AuthorDate: 2018-06-19 07:13:31 +0000
Commit:     Alon Bar-Lev <alonbl@gentoo.org>
CommitDate: 2018-06-19 07:15:17 +0000

    app-crypt/gnupg: revert removal of mta
    
    Bug: https://bugs.gentoo.org/658164

 app-crypt/gnupg/gnupg-2.2.8-r1.ebuild | 132 ----------------------------------
 1 file changed, 132 deletions(-)
Comment 13 Kristian Fiskerstrand (RETIRED) gentoo-dev 2018-06-19 08:41:46 UTC
(In reply to Alon Bar-Lev from comment #11)
> Reverting as gpg-wks-client is not optional.
> Do you think that it will be accepted as optional if I send to upstream.

My immediate reaction is "no" given focus on getting operable WKS, but it depends a bit on how MUAs etc actually implements it. I expect this to be one of the aspects discussed during the OpenPGP Email Summit in Brussels in October.
Comment 14 Duncan 2018-06-20 04:57:03 UTC
[Sigh] Good thing I didn't delete my empty-dep virtual/mta-999 that pulls in nothing, then, I guess.

gnupg builds without an mta and I don't need one for other use /or/ for my gnupg use, so why it can't be USE-flag optional is beyond me, but I'm not the gentoo gnupg maintainer, so ... an empty (local) virtual pulling nothing in it appears it must be.

That said, thanks for your work maintaining the package.  A local empty-dep virtual/mta ebuild is definitely easier to maintain than a proper ebuild for just about any real package, gnupg included, so minor disagreement aside, thanks for your work, both on this package and on gentoo in general.  There's a reason I run a distro where local overrides to such decisions are that easy. =:^)
Comment 15 Alon Bar-Lev (RETIRED) gentoo-dev 2018-06-20 05:19:34 UTC
(In reply to Duncan from comment #14)
> [Sigh] Good thing I didn't delete my empty-dep virtual/mta-999 that pulls in
> nothing, then, I guess.

You do not need this hack, use package.provided[1]

[1] https://wiki.gentoo.org/wiki//etc/portage/profile/package.provided