Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 657784 - media-gfx/sxiv-24: add USE=png and USE=jpeg
Summary: media-gfx/sxiv-24: add USE=png and USE=jpeg
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Graphics Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-11 01:56 UTC by Amlesh Sivanantham
Modified: 2019-02-10 06:47 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Revision of sxiv-24.ebuild (sxiv-24-r1.ebuild,1.21 KB, text/plain)
2018-06-11 01:56 UTC, Amlesh Sivanantham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Amlesh Sivanantham 2018-06-11 01:56:25 UTC
Created attachment 535620 [details]
Revision of sxiv-24.ebuild

Ebuild for media-gfx/sxiv does not consider whether media-libs/imlib2 has USE='png jpeg' set or not. Attached is a revision of the ebuild for version 24, which adds USE='png jpeg' to media-gfx/sxiv which will also force media-libs/imlib2 to also take on the same USE flags.
Comment 1 Jonas Stein gentoo-dev 2018-06-14 21:24:49 UTC
Thank you for your contribution. I had a short look on the ebuild. 
Here a few ideas:

• Please test the ebuild with repoman full -x https://wiki.gentoo.org/wiki/Repoman

• KEYWORDS need ~ after a version bump run ekeyword ~all YOUREBUILD
• please fix the header. (see /usr/portage/skel.ebuild and https://devmanual.gentoo.org/ebuild-writing/eapi/)

• do we really need eutils?
Comment 2 Amlesh Sivanantham 2018-06-14 21:30:08 UTC
@Jonas Stein,

I'll take a look at that and get back to you on that. I'm not sure why eutils is on there either (or what it does for that matter). I simply copied the previous ebuild of sxiv and modified to add the new USE flags.
Comment 3 Amlesh Sivanantham 2018-06-27 18:15:48 UTC
@Jonas Stein,
It seems I won't be able to work on this for a while, I'm gonna be out of the country for month and would only be getting around to working on it then.
Comment 4 Larry the Git Cow gentoo-dev 2019-02-10 06:47:06 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7de7bd180041457c3fee742b6550f0665fe4d0cd

commit 7de7bd180041457c3fee742b6550f0665fe4d0cd
Author:     Tim Harder <radhermit@gentoo.org>
AuthorDate: 2019-02-10 06:45:02 +0000
Commit:     Tim Harder <radhermit@gentoo.org>
CommitDate: 2019-02-10 06:46:47 +0000

    media-gfx/sxiv: version bump to 25
    
    Closes: https://bugs.gentoo.org/657784
    
    Signed-off-by: Tim Harder <radhermit@gentoo.org>

 media-gfx/sxiv/Manifest         |  1 +
 media-gfx/sxiv/sxiv-25.ebuild   | 62 +++++++++++++++++++++++++++++++++++++++++
 media-gfx/sxiv/sxiv-9999.ebuild |  8 +++---
 3 files changed, 67 insertions(+), 4 deletions(-)