Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 657694 - dev-libs/glib[fam] shouldn't be USE masked
Summary: dev-libs/glib[fam] shouldn't be USE masked
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-10 06:09 UTC by Mart Raudsepp
Modified: 2020-01-09 12:56 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mart Raudsepp gentoo-dev 2018-06-10 06:09:31 UTC
To my knowledge glib FAM file monitoring is required to have file monitoring for networked filesystem, as inotify doesn't work on those. So essentially we are forcing that support off for Linux since bug 413403.
Of course as I haven't noticed before and I don't remember seeing any bugs about it, maybe no-one cares about it. And I only noticed while working on glib, not because I need the support, as file monitoring seems to work fine in case of GIO network mounts (I think FAM is about NFS natively mounted stuff, etc).

But even Fedora ships this module still in a separate glib2-fam package, and I believe that's why. Meson build for 2.54 doesn't support building the fam gio module, but the support was added to meson.build recently even, signalling it's still useful - https://gitlab.gnome.org/GNOME/glib/merge_requests/71

We should review the claim of "Enabling USE="fam" on Linux for glib-2 downgrades it from direct inotify support to proxied inotify support through fam/gamin's unnecessarily" from bug 413403 and enable the support; probably should not have it be default enabled via some profile settings though..
Comment 1 Larry the Git Cow gentoo-dev 2020-01-09 12:56:03 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fedd97b17389635d1375276cb670ec60f238860d

commit fedd97b17389635d1375276cb670ec60f238860d
Author:     Ben Kohler <bkohler@gentoo.org>
AuthorDate: 2020-01-09 12:53:20 +0000
Commit:     Ben Kohler <bkohler@gentoo.org>
CommitDate: 2020-01-09 12:55:52 +0000

    profiles: remove fam from desktop profiles & unmask on glib
    
    Closes: https://bugs.gentoo.org/657694
    Closes: https://bugs.gentoo.org/697476
    
    Signed-off-by: Ben Kohler <bkohler@gentoo.org>

 profiles/default/linux/package.use.mask | 4 ----
 profiles/targets/desktop/make.defaults  | 2 +-
 2 files changed, 1 insertion(+), 5 deletions(-)