Bug 657542 – app-office/orage with dev-libs/libical-3.0.3: ical-code.c:2947:33: error: ‘struct icaltimetype’ has no member named ‘is_utc’; did you mean ‘is_date’?

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description spargeltarzan 2018-06-07 16:40:46 UTC]

Created attachment 535188 [details]
emerge log

App-Office/Orage fails to emerge with gcc 8.1

ical-code.c:2947:33: error: ‘struct icaltimetype’ has no member named ‘is_utc’; did you mean ‘is_date’?
                 next_alarm_time.is_utc        = 0;
                                 ^~~~~~
                                 is_date
make[2]: *** [Makefile:711: orage-ical-code.o] Error 1
make[2]: Leaving directory '/var/tmp/portage/app-office/orage-4.12.1-r1/work/orage-4.12.1/src'
make[1]: *** [Makefile:568: all-recursive] Error 1
make[1]: Leaving directory '/var/tmp/portage/app-office/orage-4.12.1-r1/work/orage-4.12.1'
make: *** [Makefile:455: all] Error 2
 * ERROR: app-office/orage-4.12.1-r1::gentoo failed (compile phase):
 *   emake failed

[Comment 1 spargeltarzan 2018-06-07 16:46:06 UTC]

Created attachment 535190 [details]
emerge info

[Comment 2 spargeltarzan 2018-06-07 16:47:02 UTC]

emerge -pqv '=app-office/orage-4.12.1-r1::gentoo'
[ebuild   R   ] app-office/orage-4.12.1-r1  USE="berkdb clock-panel-plugin dbus libnotify"

[Comment 3 Andreas Sturmlechner 2018-06-07 17:05:45 UTC]

Please tell us your version of libical.

[Comment 4 spargeltarzan 2018-06-12 14:12:56 UTC]

dev-libs/libical-3.0.3

[Comment 5 Andreas Sturmlechner 2018-06-12 14:17:31 UTC]

Not a GCC problem then, but code needs to be fixed for >=libical-3.

See also: https://github.com/libical/libical/pull/289

[Comment 6 Andreas Sturmlechner 2018-06-23 15:41:49 UTC]

Ping, I'd like to unmask libical-3 by the end of the month.

[Comment 7 Attila Tóth 2018-07-04 07:51:40 UTC]

Attached patch for the linked bug fixes the issue for me. The second attachment is a conditional fix - ment to work for libical below and over 3.

[Comment 8 Adrian Bassett 2018-07-04 10:52:28 UTC]

(In reply to Attila Tóth from comment #7)
> Attached patch for the linked bug fixes the issue for me. The second
> attachment is a conditional fix - ment to work for libical below and over 3.

Did you forget the patch?

[Comment 9 Attila Tóth 2018-07-04 18:17:52 UTC]

(In reply to Adrian.Bassett from comment #8)
> (In reply to Attila Tóth from comment #7)
> > Attached patch for the linked bug fixes the issue for me. The second
> > attachment is a conditional fix - ment to work for libical below and over 3.
> 
> Did you forget the patch?

Not my patch, was referred to in a former comment:
https://github.com/libical/libical/pull/289
(In reply to Adrian.Bassett from comment #8)
> (In reply to Attila Tóth from comment #7)
> > Attached patch for the linked bug fixes the issue for me. The second
> > attachment is a conditional fix - ment to work for libical below and over 3.
> 
> Did you forget the patch?

It was attached to the bug linked in a former comment:
https://bugzilla.xfce.org/show_bug.cgi?id=13997
https://bugzilla.xfce.org/attachment.cgi?id=7625

[Comment 10 Adrian Bassett 2018-07-04 18:48:01 UTC]

(In reply to Attila Tóth from comment #9)
> (In reply to Adrian.Bassett from comment #8)
> > (In reply to Attila Tóth from comment #7)
> > > Attached patch for the linked bug fixes the issue for me. The second
> > > attachment is a conditional fix - ment to work for libical below and over 3.
> > 
> > Did you forget the patch?
> 
> Not my patch, was referred to in a former comment:
> https://github.com/libical/libical/pull/289
> (In reply to Adrian.Bassett from comment #8)
> > (In reply to Attila Tóth from comment #7)
> > > Attached patch for the linked bug fixes the issue for me. The second
> > > attachment is a conditional fix - ment to work for libical below and over 3.
> > 
> > Did you forget the patch?
> 
> It was attached to the bug linked in a former comment:
> https://bugzilla.xfce.org/show_bug.cgi?id=13997
> https://bugzilla.xfce.org/attachment.cgi?id=7625

Thanks for the clarification.

[Comment 11 Adrian Bassett 2018-08-09 12:01:50 UTC]

> > It was attached to the bug linked in a former comment:
> > https://bugzilla.xfce.org/show_bug.cgi?id=13997
> > https://bugzilla.xfce.org/attachment.cgi?id=7625
> 
> Thanks for the clarification.

Finally got round to trying this by copying the second of the patches in #9 to /etc/portage/patches/app-office/orage/0001-fix-build-with-libical-version-3.patch and re-building orage-4.12.1-r1 (using an un-modified ebuild).  Can confirm patch is applied and that orage emerges without problem.  Would be good if this patch could be utilised by the orage ebuild in portage.

[Comment 12 Larry the Git Cow 2018-08-28 20:42:27 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=09ba952291d08d85ba05399997457c5d5a501538

commit 09ba952291d08d85ba05399997457c5d5a501538
Author:     James Le Cuirot <[e-mail]>
AuthorDate: 2018-08-28 20:41:52 +0000
Commit:     James Le Cuirot <[e-mail]>
CommitDate: 2018-08-28 20:41:52 +0000

    app-office/orage: Fix building with libical 3
    
    Thanks to Stefan Seyfried for the patch. It has been sent upstream.
    
    Closes: https://bugs.gentoo.org/657542
    Package-Manager: Portage-2.3.48, Repoman-2.3.10

 .../0001-fix-build-with-libical-version-3.patch    | 76 ++++++++++++++++++++++
 app-office/orage/orage-4.12.1-r1.ebuild            |  4 ++
 2 files changed, 80 insertions(+)