Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 656944 - sys-kernel/genkernel-3.5.3.3: integrated initramfs check uses wrong directory
Summary: sys-kernel/genkernel-3.5.3.3: integrated initramfs check uses wrong directory
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: genkernel (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Genkernel Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-31 05:55 UTC by Patrick Lauer
Modified: 2019-07-15 10:37 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Lauer gentoo-dev 2018-05-31 05:55:05 UTC
around line 1020:

/usr/share/genkernel/gen_initramfs.sh:          sed -i '/^.*CONFIG_INITRAMFS_SOURCE=.*$/d' ${KERNEL_DIR}/.config


This fails with out-of-source builds, most other bits use "${KERNEL_OUTPUTDIR} instead. Since there's no die/abort it just prints a 'sed: can't find file' warning.
Comment 1 Thomas Deutschmann (RETIRED) gentoo-dev 2019-03-26 09:48:17 UTC
I am wondering that you are reporting this against 3.5.3.3. This version doesn't use $KERNEL_DIR/.config -- this was fixed long time ago (2y before your bug report): https://github.com/gentoo/genkernel/commit/f9324a84796a5dbcac9d3a3fe2bead24f2853aa1

Am I missing something?

But I'll add a "|| gen_die ..." statement to guard against uncatched failures.
Comment 2 Larry the Git Cow gentoo-dev 2019-03-26 12:38:28 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/genkernel.git/commit/?id=ba8d7607b735d08eede975671edcc1e6d9b37345

commit ba8d7607b735d08eede975671edcc1e6d9b37345
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2019-03-26 09:48:59 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2019-03-26 09:48:59 +0000

    create_initramfs(): add error checking sed call which ties to delete CONFIG_INITRAMFS_SOURCE
    
    Bug: https://bugs.gentoo.org/656944
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 gen_initramfs.sh | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)