Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 656940 - [kde overlay] kde-plasma/plasma-vault: Make kde-frameworks/networkmanager-qt optional
Summary: [kde overlay] kde-plasma/plasma-vault: Make kde-frameworks/networkmanager-qt ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Gentoo KDE team
URL: https://phabricator.kde.org/D13255
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-31 02:30 UTC by Arfrever Frehtes Taifersar Arahesis
Modified: 2018-06-29 10:46 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
plasma-vault-KF5NetworkManagerQt_dependency_optional.patch (plasma-vault-KF5NetworkManagerQt_dependency_optional.patch,3.31 KB, patch)
2018-05-31 02:34 UTC, Arfrever Frehtes Taifersar Arahesis
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis 2018-05-31 02:30:42 UTC
Since https://gitweb.gentoo.org/proj/kde.git/commit/?id=0b88c69165787d476cc1664d8604ee9c5c5ecebe kde-plasma/plasma-vault::kde unconditonally depends on kde-frameworks/networkmanager-qt.
Many users do not need NetworkManager.


(kde-plasma/plasma-meta has "crypt" and "networkmanager" USE flags.
"crypt" USE flag enables dependency on kde-plasma/plasma-vault, while "networkmanager" USE flag enables dependency indirectly on net-misc/networkmanager.
"crypt" USE flag is enabled by default in profiles/default/linux/make.defaults, while "networkmanager" USE flag is not enabled in any profiles.)
Comment 1 Arfrever Frehtes Taifersar Arahesis 2018-05-31 02:34:17 UTC
Created attachment 534212 [details, diff]
plasma-vault-KF5NetworkManagerQt_dependency_optional.patch

IUSE="networkmanager"
...
DEPEND="...
        networkmanager? ( $(add_frameworks_dep networkmanager-qt) )
"
...
src_configure() {
        local mycmakeargs=(
                -DENABLE_NETWORKMANAGER=$(usex networkmanager)
        )

        kde5_src_configure
}
Comment 2 Larry the Git Cow gentoo-dev 2018-06-13 21:49:31 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=1192c81956c023c50d2ab0bf8a36e66158f0a852

commit 1192c81956c023c50d2ab0bf8a36e66158f0a852
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2018-06-13 21:45:09 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-06-13 21:48:44 +0000

    kde-plasma/plasma-vault: Add USE=networkmanager
    
    Thanks-to: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
    Bug: https://bugs.gentoo.org/656940
    Package-Manager: Portage-2.3.40, Repoman-2.3.9

 kde-plasma/plasma-vault/plasma-vault-9999.ebuild | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)
Comment 3 Till Schäfer 2018-06-29 10:13:07 UTC
It would be nice if this patch gets also backportet to 5.13.
Comment 4 Larry the Git Cow gentoo-dev 2018-06-29 10:46:28 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=ab8355de6555a802b38180d9e4a664a52bdfa82a

commit ab8355de6555a802b38180d9e4a664a52bdfa82a
Author:     Johannes Huber <johu@gentoo.org>
AuthorDate: 2018-06-29 10:44:27 +0000
Commit:     Johannes Huber <johu@gentoo.org>
CommitDate: 2018-06-29 10:44:52 +0000

    kde-plasma/plasma-vault: Backport use networkmanager
    
    Closes: https://bugs.gentoo.org/656940
    Package-Manager: Portage-2.3.41, Repoman-2.3.9

 .../files/plasma-vault-5.13.2-nm-qt-optional.patch | 74 ++++++++++++++++++++++
 kde-plasma/plasma-vault/plasma-vault-5.13.2.ebuild | 14 +++-
 .../plasma-vault/plasma-vault-5.13.49.9999.ebuild  | 14 +++-
 3 files changed, 98 insertions(+), 4 deletions(-)