This package installs over 700 header files by calling 'doins' on every single one of them. Thanks to the Python doins implementation in Portage, it does 2-3 files per second, and the whole thing takes around 5 minutes. Please pass multiple files to doins to speed this up. This is trivial to do by iterating over directories instead of globbing straight in for.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=93e113d4477dccfc195947272eeb76cc6e9d42ef commit 93e113d4477dccfc195947272eeb76cc6e9d42ef Author: Michał Górny <mgorny@gentoo.org> AuthorDate: 2018-06-13 06:51:23 +0000 Commit: Zero_Chaos <zerochaos@gentoo.org> CommitDate: 2018-06-28 14:43:05 +0000 net-analyzer/wireshark: Fix install to avoid calling doins per-file Call doins per-directory rather than per-file. doins accept multiple arguments, so it's entirely silly to iterate and call it separately for each file; not to mention that thanks to new Python implementation in Portage it is veeeeery slow. This patch reduces install time by around 10 minutes. Closes: https://bugs.gentoo.org/656834 net-analyzer/wireshark/wireshark-2.6.1.ebuild | 41 +++++++++++---------------- 1 file changed, 17 insertions(+), 24 deletions(-)
The bad code has been reintroduced by jer@ in 2.9.0.
(In reply to Michał Górny from comment #2) > The bad code has been reintroduced by jer@ in 2.9.0. What you should have said is that your commit didn't fix the live ebuild.
What you also failed to mention is that your changes were not offered up for review and that you closed the bug report with your commit-fu, taking it off the radar.
(In reply to Jeroen Roovers from comment #4) > What you also failed to mention is that your changes were not offered up for > review and that you closed the bug report with your commit-fu, taking it off > the radar. I would appreciate that if you investigated the facts instead of accusing me based on your imagination. My changes were reviewed and committed by zero-chaos (which you would have known if you looked at git log). If you have trouble communicating within the team, then I would suggest you fix it yourself. As far as I'm concerned, developers aren't expected to special-case Mr. Jeroen and pass everything through him explicitly because he's too important to communicate with his fellow team members or care about what happens to his packages.
(In reply to Michał Górny from comment #5) > My changes were reviewed and committed by > zero-chaos (which you would have known if you looked at git log). Exactly my point except that you didn't commit them. Fair enough.
And what's that "home-made" reference good for? I'm pretty sure it was written in an office, probably my office. You replaced it with other code that may or may not be labelled "home-made", so whatever the purpose was, it looks like it's either meaningless or derogatory.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a5ae2b3242b616030e6b9ad5837f659df7bd899f commit a5ae2b3242b616030e6b9ad5837f659df7bd899f Author: Jeroen Roovers <jer@gentoo.org> AuthorDate: 2018-12-16 14:45:47 +0000 Commit: Jeroen Roovers <jer@gentoo.org> CommitDate: 2018-12-16 14:47:27 +0000 net-analyzer/wireshark: "Add home-grown" code to make doins faster While there, fix tfshark linking in the live ebuild, too. Package-Manager: Portage-2.3.52, Repoman-2.3.12 Fixes: https://bugs.gentoo.org/656834 Signed-off-by: Jeroen Roovers <jer@gentoo.org> net-analyzer/wireshark/wireshark-2.9.0-r1.ebuild | 41 ++++++++++------------- net-analyzer/wireshark/wireshark-99999999.ebuild | 42 ++++++++++-------------- 2 files changed, 35 insertions(+), 48 deletions(-)
