Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 656814 - media-sound/wildmidi-0.2.3.5 QA issues, has no fileguards in its headers
Summary: media-sound/wildmidi-0.2.3.5 QA issues, has no fileguards in its headers
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal QA (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2018-05-28 21:24 UTC by mudcrabmerchant
Modified: 2020-10-31 15:58 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description mudcrabmerchant 2018-05-28 21:24:27 UTC
Stablized package media-sound/wildmidi-0.2.3.5 includes headers that don't have file guards, and building against with a custom ebuild (available on request) results in compiling errors.

The Wildmidi Player ($ wildmidi) selected by the useflag 'Player' also has a problem in its default configuration does not point to the correct directory where the instument samples(?) are located. The first line needs to be changed to 'dir /usr/share/timidity/freepats' in order to work.
Comment 1 Andreas Sturmlechner gentoo-dev 2018-09-30 15:48:36 UTC
Please test with current stable wildmidi-0.3.13.
Comment 2 Larry the Git Cow gentoo-dev 2020-10-31 15:58:57 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8bfe6eeb3e79cf2d8b72c39fe91d8e75f040740f

commit 8bfe6eeb3e79cf2d8b72c39fe91d8e75f040740f
Author:     Azamat H. Hackimov <azamat.hackimov@gmail.com>
AuthorDate: 2020-10-29 20:16:19 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-10-31 15:58:44 +0000

    media-sound/wildmidi: update 0.4.3
    
    Migrated to EAPI 7, fixed timidity-freepats location in config, removed
    unused files.
    
    Closes: https://bugs.gentoo.org/656814
    Closes: https://bugs.gentoo.org/749759
    Package-Manager: Portage-3.0.8, Repoman-3.0.2
    Signed-off-by: Azamat H. Hackimov <azamat.hackimov@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/18069
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 media-sound/wildmidi/Manifest              |   1 +
 media-sound/wildmidi/files/wildmidi.cfg    | 138 -----------------------------
 media-sound/wildmidi/metadata.xml          |   9 +-
 media-sound/wildmidi/wildmidi-0.4.3.ebuild |  59 ++++++++++++
 4 files changed, 68 insertions(+), 139 deletions(-)