This causes wrong checksums / verification failures. Reproducible: Always Steps to Reproduce: 1. Copy an ebuild from last year to a new ebuild that targets a new version. 2. Update necessary stuff in the new ebuild besides the copyright header, then run 'repoman commit'. 3. Merge the new ebuild with 'ebuild'. Or maybe just run 'repoman'. Actual Results: * Digest verification failed: * ... * Reason: Failed on BLAKE2B verification * Got: 1b9a64d97924c1c61d2015c1561332812a4d843da03e38e66698540743a81101bfbd96f92ffd3f448d6bd7f22cd04f8c485d0d8ad156786486690fde7c7f2f66 * Expected: 5a33d2b8d312a121a9e8092df209ceef6941c14f5be011a395faae293c379fb8887532eb62fc9840af8731ac9981663fdf567a7534caab91317ccb7d1fd824ee
It calls the update_copyright function here: https://gitweb.gentoo.org/proj/portage.git/tree/repoman/pym/repoman/actions.py?h=repoman-2.3.9#n157 When needs_keyword_expansion is False it skips the thick_manifest call here: https://gitweb.gentoo.org/proj/portage.git/tree/repoman/pym/repoman/actions.py?h=repoman-2.3.9#n173 It calls digest_regen unconditionally here: https://gitweb.gentoo.org/proj/portage.git/tree/repoman/pym/repoman/actions.py?h=repoman-2.3.9#n209 However, the digest_regen implementation for git does nothing unless changelog generation is enabled, since it relies on the broken_changelog_manifests variable: https://gitweb.gentoo.org/proj/portage.git/tree/repoman/pym/repoman/modules/vcs/git/changes.py?h=repoman-2.3.9#n67
So what is the plan with this? I just was hit by this. It is annoying when repoman gives you this nice warm feeling when it says: "If everyone were like you, I'd be out of business!" Just to laugh at you behind your back 'cause it broke the manifest again without you noticing.
I'd like to get this fixed for the next repoman release.
Patch posted for review: https://archives.gentoo.org/gentoo-portage-dev/message/b772113d4181ac3dc75095593bb2b3bb https://github.com/gentoo/portage/pull/367
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/portage.git/commit/?id=4ff4e4200b984a88109b10de9e82b20451751aee commit 4ff4e4200b984a88109b10de9e82b20451751aee Author: Zac Medico <zmedico@gentoo.org> AuthorDate: 2018-09-20 20:35:42 +0000 Commit: Zac Medico <zmedico@gentoo.org> CommitDate: 2018-09-22 08:23:14 +0000 repoman: regen thick manifest after copyright update (bug 656698) Bug: https://bugs.gentoo.org/656698 repoman/lib/repoman/actions.py | 40 ++++++++++++++++++++++++++++++++++++++- repoman/lib/repoman/copyrights.py | 10 ++++++++++ 2 files changed, 49 insertions(+), 1 deletion(-)
Please test with repoman-2.3.11 which includes the fix.
