Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 656532 - [kde overlay] kde-plasma/plasma-browser-integration does not respect libdir for its firefox native messaging host manifest
Summary: [kde overlay] kde-plasma/plasma-browser-integration does not respect libdir f...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Overlays (show other bugs)
Hardware: AMD64 Linux
: Low minor
Assignee: Gentoo KDE team
URL: https://phabricator.kde.org/D13188
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2018-05-25 22:09 UTC by Alexander Konstantinov
Modified: 2018-05-30 01:21 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
fix (0001-kde-plasma-plasma-browser-integration-install-manife.patch,2.53 KB, patch)
2018-05-25 22:09 UTC, Alexander Konstantinov 		Details | Diff
Patch for CMakeLists.txt (mozilla_dir_option.patch,1.69 KB, patch)
2018-05-27 07:54 UTC, Arfrever Frehtes Taifersar Arahesis 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Konstantinov 2018-05-25 22:09:24 UTC 
Created attachment 533256 [details, diff]
fix

plasma-browser-integration doesn't work in firefox

Reason:
On a AMD64 system firefox searches for host manifests in /usr/lib64/mozilla/native-messaging-hosts (see https://searchfox.org/mozilla-central/source/toolkit/xre/nsXREDirProvider.cpp#273 ) but plasma-browser-integration installs it in /usr/lib/mozilla/native-messaging-hosts

Solution:
Patch the CMakeLists to install the manifest to /usr/$(get_libdir)/mozilla/native-messaging-hosts instead
Comment 1 Arfrever Frehtes Taifersar Arahesis 2018-05-26 05:07:37 UTC 
Maybe better to patch CMakeLists.txt to accept an option which would specify path where this file should be installed.
Comment 2 Arfrever Frehtes Taifersar Arahesis 2018-05-27 07:54:30 UTC 
Created attachment 533434 [details, diff]
Patch for CMakeLists.txt
Comment 3 Arfrever Frehtes Taifersar Arahesis 2018-05-27 07:57:24 UTC 
When using this patch, ebuild should have:

src_configure() {
       local mycmakeargs=(
               -DMOZILLA_DIR="${EPREFIX}/usr/$(get_libdir)/mozilla"
       )

       kde5_src_configure
}
Comment 4 Larry the Git Cow gentoo-dev 2018-05-29 23:05:26 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=d26b8d9cccf22e147a59499cc0a0b1f68196422c

commit d26b8d9cccf22e147a59499cc0a0b1f68196422c
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2018-05-29 23:03:57 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-05-29 23:03:57 +0000

    kde-plasma/plasma-browser-integration: Fix Mozilla dir
    
    Upstream commit 9a4e032c04fd567a3b3a5d2e050a22abd689d575
    Thanks-to: Arfrever Frehtes Taifersar Arahesis <arfrever.fta@gmail.com>
    Closes: https://bugs.gentoo.org/656532
    Package-Manager: Portage-2.3.40, Repoman-2.3.9

 ...rowser-integration-5.12.90-respect-libdir.patch | 35 ++++++++++++++++++++++
 ...> plasma-browser-integration-5.12.90-r1.ebuild} | 16 ++++++++--
 .../plasma-browser-integration-5.13.49.9999.ebuild | 14 +++++++--
 .../plasma-browser-integration-9999.ebuild         | 14 +++++++--
 4 files changed, 70 insertions(+), 9 deletions(-)