Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 656520 - media-gfx/maim-5.5.1 : /.../image.cpp:190:74: error: cannot convert bool to boolean for argument 3 to void jpeg_set_quality(j_compress_ptr, int, boolean)
Summary: media-gfx/maim-5.5.1 : /.../image.cpp:190:74: error: cannot convert bool to b...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-25 19:17 UTC by Toralf Förster
Modified: 2019-04-11 17:08 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,16.54 KB, text/plain)
2018-05-25 19:17 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,268.78 KB, text/plain)
2018-05-25 19:17 UTC, Toralf Förster
Details
environment (environment,110.73 KB, text/plain)
2018-05-25 19:17 UTC, Toralf Förster
Details
etc.portage.tbz2 (etc.portage.tbz2,23.26 KB, application/x-bzip)
2018-05-25 19:17 UTC, Toralf Förster
Details
logs.tbz2 (logs.tbz2,4.18 KB, application/x-bzip)
2018-05-25 19:17 UTC, Toralf Förster
Details
media-gfx:maim-5.5.1:20180525-191212.log (media-gfx:maim-5.5.1:20180525-191212.log,6.32 KB, text/plain)
2018-05-25 19:17 UTC, Toralf Förster
Details
temp.tbz2 (temp.tbz2,27.48 KB, application/x-bzip)
2018-05-25 19:17 UTC, Toralf Förster
Details
emerge-info.txt (emerge-info.txt,15.64 KB, text/plain)
2018-10-08 15:03 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,103.44 KB, text/plain)
2018-10-08 15:03 UTC, Toralf Förster
Details
environment (environment,106.82 KB, text/plain)
2018-10-08 15:03 UTC, Toralf Förster
Details
etc.portage.tbz2 (etc.portage.tbz2,13.16 KB, application/x-bzip)
2018-10-08 15:03 UTC, Toralf Förster
Details
logs.tbz2 (logs.tbz2,4.26 KB, application/x-bzip)
2018-10-08 15:03 UTC, Toralf Förster
Details
media-gfx:maim-5.5.1:20181008-145554.log (media-gfx:maim-5.5.1:20181008-145554.log,6.88 KB, text/plain)
2018-10-08 15:03 UTC, Toralf Förster
Details
temp.tbz2 (temp.tbz2,26.45 KB, application/x-bzip)
2018-10-08 15:03 UTC, Toralf Förster
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2018-05-25 19:17:16 UTC
/var/tmp/portage/media-gfx/maim-5.5.1/work/maim-5.5.1/src/image.cpp: In member function ‘void ARGBImage::writeJPEG(std::ostream&, int)’:
/var/tmp/portage/media-gfx/maim-5.5.1/work/maim-5.5.1/src/image.cpp:190:74: error: cannot convert ‘bool’ to ‘boolean’ for argument ‘3’ to ‘void jpeg_set_quality(j_compress_ptr, int, boolean)’
     jpeg_set_quality (&cinfo, (int)((float)quality-1.f)*(100.f/9.f), true);
                                                                          ^
/var/tmp/portage/media-gfx/maim-5.5.1/work/maim-5.5.1/src/image.cpp:191:37: error: cannot convert ‘bool’ to ‘boolean’ for argument ‘2’ to ‘void jpeg_start_compress(j_compress_ptr, boolean)’

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.0-hardened_20180519-101508

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-7.3.0 *

Available Python interpreters, in order of preference:
  [1]   python3.5
  [2]   python2.7 (fallback)
  [3]   pypy (fallback)
Available Ruby profiles:
  [1]   ruby23 (with Rubygems) *



emerge -qpv media-gfx/maim
[ebuild  N    ] media-gfx/maim-5.5.1  USE="unicode" 

!!! The following installed packages are masked:
- kde-frameworks/kdelibs-env-4.14.3::gentoo (masked by: package.mask)
/usr/portage/profiles/package.mask:
# Andreas Sturmlechner <asturm@gentoo.org> (24 May 2018)
# Depends on dead Qt4. Masked for removal in 30 days. Bug #629018

For more information, see the MASKED PACKAGES section in the emerge
man page or refer to the Gentoo Handbook.
Comment 1 Toralf Förster gentoo-dev 2018-05-25 19:17:19 UTC
Created attachment 533208 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2018-05-25 19:17:22 UTC
Created attachment 533210 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2018-05-25 19:17:25 UTC
Created attachment 533212 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2018-05-25 19:17:28 UTC
Created attachment 533214 [details]
etc.portage.tbz2
Comment 5 Toralf Förster gentoo-dev 2018-05-25 19:17:31 UTC
Created attachment 533216 [details]
logs.tbz2
Comment 6 Toralf Förster gentoo-dev 2018-05-25 19:17:35 UTC
Created attachment 533218 [details]
media-gfx:maim-5.5.1:20180525-191212.log
Comment 7 Toralf Förster gentoo-dev 2018-05-25 19:17:38 UTC
Created attachment 533220 [details]
temp.tbz2
Comment 8 Pacho Ramos gentoo-dev 2018-10-08 14:12:19 UTC
are you still able to reproduce? In my case it compiles ok
Comment 9 Toralf Förster gentoo-dev 2018-10-08 15:03:26 UTC
got at the unstable amd64 chroot image 17.0_libressl_20181006-210858 this : /.../image.cpp:190:74: error: cannot convert bool to boolean
Comment 10 Toralf Förster gentoo-dev 2018-10-08 15:03:29 UTC
Created attachment 549922 [details]
emerge-info.txt
Comment 11 Toralf Förster gentoo-dev 2018-10-08 15:03:32 UTC
Created attachment 549924 [details]
emerge-history.txt
Comment 12 Toralf Förster gentoo-dev 2018-10-08 15:03:34 UTC
Created attachment 549926 [details]
environment
Comment 13 Toralf Förster gentoo-dev 2018-10-08 15:03:37 UTC
Created attachment 549928 [details]
etc.portage.tbz2
Comment 14 Toralf Förster gentoo-dev 2018-10-08 15:03:40 UTC
Created attachment 549930 [details]
logs.tbz2
Comment 15 Toralf Förster gentoo-dev 2018-10-08 15:03:42 UTC
Created attachment 549932 [details]
media-gfx:maim-5.5.1:20181008-145554.log
Comment 16 Toralf Förster gentoo-dev 2018-10-08 15:03:45 UTC
Created attachment 549934 [details]
temp.tbz2
Comment 17 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-03-23 19:05:29 UTC
I'm going to guess this is because of using the original jpeg library instead of libjpeg-turbo.
Comment 18 Toralf Förster gentoo-dev 2019-03-23 19:07:07 UTC
(In reply to Michał Górny from comment #17)
> I'm going to guess this is because of using the original jpeg library
> instead of libjpeg-turbo.

FWIW jpeg is forced by https://github.com/toralf/tinderbox/blob/master/bin/setup_img.sh#L526 iun every 6th image
Comment 19 Larry the Git Cow gentoo-dev 2019-04-11 10:38:57 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=92d976e1989d6a319bad89b4c83d0507a80be435

commit 92d976e1989d6a319bad89b4c83d0507a80be435
Author:     David Seifert <soap@gentoo.org>
AuthorDate: 2019-04-11 10:36:50 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2019-04-11 10:38:40 +0000

    media-gfx/maim: Fix building with libjpeg
    
    Bug: https://bugs.gentoo.org/656520
    Package-Manager: Portage-2.3.62, Repoman-2.3.12
    Signed-off-by: David Seifert <soap@gentoo.org>

 media-gfx/maim/files/maim-5.5.1-libjpeg-9c.patch | 16 ++++++++++++++++
 media-gfx/maim/maim-5.5.1.ebuild                 |  4 +++-
 2 files changed, 19 insertions(+), 1 deletion(-)
Comment 20 David Seifert gentoo-dev 2019-04-11 10:40:15 UTC
@Toralf, could you please give this another try (on a libjpeg image obviously), I can get upstream to cut a new release with the patch.
Comment 21 Toralf Förster gentoo-dev 2019-04-11 16:57:35 UTC
(In reply to David Seifert from comment #20)
> @Toralf, could you please give this another try (on a libjpeg image
> obviously), I can get upstream to cut a new release with the patch.

works:

tinderbox@mr-fox ~ $ qlop -u -l -f  /home/tinderbox/run/17.1-desktop-plasma_abi32+64_20190410-101928/var/log/emerge.log media-gfx/maim
Thu Apr 11 18:47:07 2019 >>> media-gfx/maim-5.5.1
tinderbox@mr-fox ~ $ qlop -u -l -f  /home/tinderbox/run/17.1-desktop-plasma_abi32+64_20190410-101928/var/log/emerge.log media-libs/jpeg
Wed Apr 10 15:34:10 2019 >>> media-libs/jpeg-9c
Thu Apr 11 06:59:54 2019 >>> media-libs/jpeg-6b-r12
Comment 22 David Seifert gentoo-dev 2019-04-11 17:08:45 UTC
Thanks for testing, fixed.