Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 656368 - sys-apps/systemd-238-r6 test failures on sparc - 76/244 test-util, 177/244 test-bus-cleanup, 179/244 test-bus-track
Summary: sys-apps/systemd-238-r6 test failures on sparc - 76/244 test-util, 177/244 te...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: Sparc Linux
: Normal normal (vote)
Assignee: Gentoo systemd Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-23 21:02 UTC by Ben Kohler
Modified: 2018-05-24 20:33 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
testlog.txt.xz (testlog.txt.xz,98.76 KB, application/octet-stream)
2018-05-23 21:02 UTC, Ben Kohler
Details
Fix raw_clone on 32-bit sparc (raw-clone.patch,1.33 KB, patch)
2018-05-24 05:37 UTC, Mike Gilbert
Details | Diff
emerge --info (info.txt,4.90 KB, text/plain)
2018-05-24 14:24 UTC, Ben Kohler
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Kohler gentoo-dev 2018-05-23 21:02:30 UTC
Created attachment 532806 [details]
testlog.txt.xz

I'm seeing 3 test failures on sparc for systemd-238-r6.  It was suggested that some of these are due to not having systemd running as pid1, but I am fully booted via systemd on this machine now.
Comment 1 Ben Kohler gentoo-dev 2018-05-23 21:08:53 UTC
Here are the details on failing ones (adding to comments because I know it's annoying to have to download & unpack the big log):

 76/244 test-util                               FAIL     2.00 s

--- command ---
SYSTEMD_KBD_MODEL_MAP='/var/tmp/portage/sys-apps/systemd-238-r6/work/systemd-238/src/locale/kbd-model-map' PATH='/var/tmp/portage/sys-apps/systemd-238-r6/work/systemd-238-.sparc32:/var/tmp/portage/sys-apps/systemd-238-r6/temp/python3.5/bin:/usr/lib/portage/python3.5/ebuild-helpers/xattr:/usr/lib/portage/python3.5/ebuild-helpers:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/sparc-unknown-linux-gnu/gcc-bin/6.4.0:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/bin' SYSTEMD_LANGUAGE_FALLBACK_MAP='/var/tmp/portage/sys-apps/systemd-238-r6/work/systemd-238/src/locale/language-fallback-map' /var/tmp/portage/sys-apps/systemd-238-r6/work/systemd-238-.sparc32/test-util
--- stderr ---
before clone: getpid()�~F~R22517
raw_clone: 22522 getpid()�~F~R22517 raw_getpid()�~F~R22517
raw_clone: 22517 getpid()�~F~R22522 raw_getpid()�~F~R22522
Assertion 'pid2 == parent' failed at ../systemd-238/src/test/test-util.c:226, function test_raw_clone(). Aborting.
Assertion 'WIFEXITED(status) && WEXITSTATUS(status) == EXIT_SUCCESS' failed at ../systemd-238/src/test/test-util.c:228, function test_raw_clone(). Aborting.
-------

177/244 test-bus-cleanup                        FAIL     1.31 s

--- command ---
SYSTEMD_KBD_MODEL_MAP='/var/tmp/portage/sys-apps/systemd-238-r6/work/systemd-238/src/locale/kbd-model-map' PATH='/var/tmp/portage/sys-apps/systemd-238-r6/work/systemd-238-.sparc32:/var/tmp/portage/sys-apps/systemd-238-r6/temp/python3.5/bin:/usr/lib/portage/python3.5/ebuild-helpers/xattr:/usr/lib/portage/python3.5/ebuild-helpers:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/sparc-unknown-linux-gnu/gcc-bin/6.4.0:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/bin' SYSTEMD_LANGUAGE_FALLBACK_MAP='/var/tmp/portage/sys-apps/systemd-238-r6/work/systemd-238/src/locale/language-fallback-map' /var/tmp/portage/sys-apps/systemd-238-r6/work/systemd-238-.sparc32/test-bus-cleanup
--- stderr ---
Assertion 'r >= 0' failed at ../systemd-238/src/libsystemd/sd-bus/test-bus-cleanup.c:45, function test_bus_open(). Aborting.
-------

179/244 test-bus-track                          FAIL     1.22 s

--- command ---
SYSTEMD_KBD_MODEL_MAP='/var/tmp/portage/sys-apps/systemd-238-r6/work/systemd-238/src/locale/kbd-model-map' PATH='/var/tmp/portage/sys-apps/systemd-238-r6/work/systemd-238-.sparc32:/var/tmp/portage/sys-apps/systemd-238-r6/temp/python3.5/bin:/usr/lib/portage/python3.5/ebuild-helpers/xattr:/usr/lib/portage/python3.5/ebuild-helpers:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/sparc-unknown-linux-gnu/gcc-bin/6.4.0:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/bin' SYSTEMD_LANGUAGE_FALLBACK_MAP='/var/tmp/portage/sys-apps/systemd-238-r6/work/systemd-238/src/locale/language-fallback-map' /var/tmp/portage/sys-apps/systemd-238-r6/work/systemd-238-.sparc32/test-bus-track
--- stderr ---
Assertion 'r >= 0' failed at ../systemd-238/src/libsystemd/sd-bus/test-bus-track.c:76, function main(). Aborting.
-------

OK:       227
FAIL:       3
SKIP:      14
TIMEOUT:    0
Comment 2 Mike Gilbert gentoo-dev 2018-05-24 05:11:00 UTC
Is this a 32-bit sparc system?

I'm thinking the sparc64 logic from this commit might also need to be applied on sparc.

https://github.com/systemd/systemd/commit/8869a0b40b1cf82d264cabc2ff8052e8e35145a2
Comment 3 Mike Gilbert gentoo-dev 2018-05-24 05:37:31 UTC
Created attachment 532808 [details, diff]
Fix raw_clone on 32-bit sparc

Can you apply this patch and re-run test-util?
Comment 4 Mike Gilbert gentoo-dev 2018-05-24 05:57:01 UTC
On test-bus-cleanup and test-bus-track: it looks like it is failing to connect to the user bus.

Do you have sys-apps/dbus[user-session] enabled? If not, can you enable that USE flag and retry the tests?
Comment 5 Mike Gilbert gentoo-dev 2018-05-24 05:58:34 UTC
If sys-apps/dbus[user-session] does not fix it, it would be helpful if you could run the tests using strace and provide the resulting log.
Comment 6 Ben Kohler gentoo-dev 2018-05-24 14:24:49 UTC
Created attachment 532826 [details]
emerge --info

This is a 64bit kernel on 32bit userland (which is the only officially supported sparc setup on gentoo right now, afaik).  Here is emerge --info.  One thing that might be worth noting is that I do have unkeyworded glibc-2.27, using that for some specific sparc fixes it brings.  Also using binutils-2.28 (not latest) for specific sparc issues.  Other than that, I think I have a pretty vanilla/boring ~sparc setup.

I have tested your patch and test 76 (test-util) does now succeed.  The 2 dbus tests are still failing after adding USE=user-session.

# emerge -pv dbus systemd

These are the packages that would be merged, in order:

[ebuild   R    ] sys-apps/dbus-1.12.8::gentoo  USE="systemd user-session -X -debug -doc (-elogind) (-selinux) -static-libs {-test}" 0 KiB
[ebuild   R    ] sys-apps/systemd-238-r6:0/2::gentoo  USE="acl gcrypt kmod lz4 pam pcre ssl sysv-utils (-apparmor) -audit -build -cryptsetup -curl -elfutils (-gnuefi) -http -idn -importd -libidn2 -lzma -nat -policykit -qrcode (-seccomp) (-selinux) {-test} -usrmerge -vanilla -xkb" 0 KiB

Total: 2 packages (2 reinstalls), Size of downloads: 0 KiB

#
Comment 7 Ben Kohler gentoo-dev 2018-05-24 15:17:54 UTC
I just tried "ebuild systemd-238-r6.ebuild test" (after a clean) as my non-root user (who's in portage group) and my result is:

OK:       228
FAIL:       0
SKIP:      16
TIMEOUT:    0

What do you make of that?
Comment 8 Larry the Git Cow gentoo-dev 2018-05-24 20:33:08 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ec933bb0dda9b1771bf3f53d2bfb835040dfa07a

commit ec933bb0dda9b1771bf3f53d2bfb835040dfa07a
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2018-05-24 20:32:44 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2018-05-24 20:33:03 +0000

    sys-apps/systemd: fix raw_clone() on sparc
    
    Closes: https://bugs.gentoo.org/656368
    Package-Manager: Portage-2.3.37, Repoman-2.3.9_p219

 sys-apps/systemd/files/238-sparc-raw-clone.patch   | 42 ++++++++++++++++++++++
 ...systemd-238-r6.ebuild => systemd-238-r7.ebuild} |  1 +
 2 files changed, 43 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c9a5a3a15785d54b014af8ec4f4e340ca16f7412

commit c9a5a3a15785d54b014af8ec4f4e340ca16f7412
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2018-05-24 20:27:21 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2018-05-24 20:33:03 +0000

    sys-apps/systemd: unset DBUS_SESSION_BUS_ADDRESS and XDG_RUNTIME_DIR for tests
    
    Bug: https://bugs.gentoo.org/656368

 sys-apps/systemd/systemd-238-r6.ebuild | 1 +
 sys-apps/systemd/systemd-9999.ebuild   | 1 +
 2 files changed, 2 insertions(+)