Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 655914 - app-misc/nnn should use /usr/share/fish/vendor_completions.d/ for fish completions
Summary: app-misc/nnn should use /usr/share/fish/vendor_completions.d/ for fish comple...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mikle Kolyada (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-16 20:04 UTC by Georgy Yakovlev
Modified: 2018-08-15 05:49 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Georgy Yakovlev archtester gentoo-dev 2018-05-16 20:04:25 UTC
Hi,

/usr/share/fish/vendor_completions.d/ should be used as a completion dir for 3rd party installed completions.
(see sys-apps/fd, sys-apps/exa, app-admin/pass)

It does not really cause problems, but it's a bit unexpected, because mentioned dir exists exactly for this purpose.

I maintain fish-shell in gentoo, and upstream specifically encourages to use that dir.
It's not created by fish ebuild (because there is no corresponding keepdir call), but fish will load files from there.


And by the way, would you consider simplifying the ebuild?

remove completion USE flags
remove conditional deps on zfs and fish
install completions unconditionally.

As far as I know it's against policy to control installation of small files/completions using use-flags, unless strictly required by package.
Users can filter out that kind of stuff using INSTALL_MASK

I can work on it and submit a PR if you are short on time to implement that.
Comment 1 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2018-05-25 19:54:57 UTC
Ok, but to your information

>As far as I know it's against policy to control installation of small >files/completions using use-flags, unless strictly required by package.
>Users can filter out that kind of stuff using INSTALL_MASK

There is *no* such a *policy*
Comment 2 Georgy Yakovlev archtester gentoo-dev 2018-05-25 20:12:34 UTC
I might got it wrong, sorry about that.
seems it's a policy for bash-completions and just a suggestion for some other small files.

But it makes sense to me and I suggested it while reporting completion-related bug.
Comment 3 Larry the Git Cow gentoo-dev 2018-08-15 05:49:34 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=77801f40e8e05978b957dd76f578c399054a2193

commit 77801f40e8e05978b957dd76f578c399054a2193
Author:     Mikle Kolyada <zlogene@gentoo.org>
AuthorDate: 2018-08-15 05:48:52 +0000
Commit:     Mikle Kolyada <zlogene@gentoo.org>
CommitDate: 2018-08-15 05:49:21 +0000

    app-misc/nnn: Version bump (v1.9)
    
    - Install the completion files unconditionally (tiny)
    - Fix the installation path for fish completion
    - Drop empty IUSE
    
    Closes: https://bugs.gentoo.org/655914
    Closes: https://bugs.gentoo.org/663306
    Package-Manager: Portage-2.3.40, Repoman-2.3.9

 app-misc/nnn/Manifest       |  1 +
 app-misc/nnn/nnn-1.9.ebuild | 39 +++++++++++++++++++++++++++++++++++++++
 2 files changed, 40 insertions(+)