Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 655426 - gnome-base/gnome-shell - make telepathy optional at runtime
Summary: gnome-base/gnome-shell - make telepathy optional at runtime
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-10 21:54 UTC by Yaroslav Isakov
Modified: 2018-09-28 13:51 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yaroslav Isakov 2018-05-10 21:54:59 UTC
Hello! It looks like telepathy now is optional run-time dependency for gnome-shell, according to this NEWS line:
* Make telepathy optional at runtime [Florian; #771721, #779878]

So, please, add a new use-flag instead of unconditionally requiring telepathy-(glib|logger)
Comment 1 Yaroslav Isakov 2018-05-11 17:38:25 UTC
As it runtime only check, maybe it would be better to not have a use flag as well, but inform user that he can install telepathy package...
Comment 2 Mart Raudsepp gentoo-dev 2018-09-19 10:43:32 UTC
I did the USE flag in 3.26.2-r3 in gnome overlay, which I intend to trickle into main tree hopefully later this week. But indeed, just implicit might be even more appropriate, as if empathy or something is installed, the deps will be present anyways and things magically work.
However on second thought, gnome-shell needs USE=introspection on them to function, which a C chat client would not need, thus it might still be useful to have the USE flag to ensure functionality.
Thus I think I'll keep it as such (the metadata.xml description already tells "_Ensure_ presence of telepathy chat integration"), and then it'll just also work without USE=telepathy when the appropriate deps happen to be installed with USE=introspection (the default afaik).
So this bug is basically waiting gnome-shell-3.26 introduction to main tree (pending review of control-center, gjs and co and gdm from my end), and then it's fixed.
Comment 3 Larry the Git Cow gentoo-dev 2018-09-28 13:51:26 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4f874177a1bcee5a10fde56cd58ab5860a7a07b8

commit 4f874177a1bcee5a10fde56cd58ab5860a7a07b8
Author:     Mart Raudsepp <leio@gentoo.org>
AuthorDate: 2018-09-27 21:36:24 +0000
Commit:     Mart Raudsepp <leio@gentoo.org>
CommitDate: 2018-09-28 13:49:13 +0000

    gnome-base/gnome-shell: bump to 3.26.2, support elogind, many tweaks
    
    * Port ebuild to use meson (no autotools upstream anymore)
    * Support elogind and get rid of unnecessary openrc-force hacks;
      gnome-shell systemd code only handles journald integration - logging
      structured data to it itself, instead of plain g_prints and telling
      it about launched apps, so they get to log under their own identifier
      instead of gnome-session. The -Denable-systemd option only deals with
      that, so we can safely just not pass it on non-systemd systems. The
      suspend support is handled purely via logind dbus interfaces and is
      build unconditionally - at runtime it is conditional on
      /run/systemd/seats existing and being accessible, which should be the
      case with newer elogind (with relevant bugs fixed) by my quick
      research, but I have not tested personally. Don't make a big deal
      about lacking suspend and seat inhibition support and just pull in
      a logind interface provider (techically this is runtime only, but
      not bothering with a separate DEPEND-free RDEPEND block for elogind).
      The alternative (to require logind) would be to require one of the
      systemd or elogind USE flags instead of at-most-one-of, but this is
      runtime optional anyways, so don't block it - user could just build
      with systemd and boot with something else, for example, and similarly
      not have this work at runtime). Also remove some ewarns appropriately.
    * Build-time depend on systemd with USE=systemd for the aforementioned
      journald integration, which needs systemd present at build time already.
    * More appropriately use python-single-r1 instead of python-r1 for the two
      small python utilities. Hack meson to update to the correct shebang.
    * Make telepathy optional - it was made runtime optional in 3.24 already,
      and with empathy being in the state it's in, the chat integration is
      rather unused on a desktop system.
    * Remove questionable glib USE=dbus requirement - if dconf is required,
      it should be depended upon directly; but as this is just your typical
      GSettings memory vs dconf backend scenario, I don't see why that'd be.
    * Remove unnecessary libXtst depend - I can't find any usage of it in
      current version (only mentions of caribou using it, which has its own
      dep and is optional on-screen keyboard support, gone in newer versions).
    * Move dbus-glib depend inside USE=networkmanager, as this legacy thing
      is for some reason (instead of GDbus) still used only in a NM specific
      source file that doesn't get compiled with USE=-networkmanager afaics.
    * Require introspection on nm-applet with USE=networkmanager, as NMGtk
      GIR is used.
    * Remove bogus mesa-progs depend - no glxinfo/glxgears usages here.
    * Add glib-utils build depend.
    * Drop dejavu font depend - I don't think we should be pulling in a
      specific font these days for some glyphs; and if we should, then it
      probably should be cantarell.
    * Require USE=glib on pulseaudio, as libpulse-mainloop-glib is linked to
      in a subproject, not just libpulse.
    * Simplify the pax-mark logic, as we don't use so old spidermonkey for so
      long, and pax-mark stuff is not tested by us. But the old complicated
      conditionals don't apply in many cases, so simplify it to just the common
      case. Additionally newer spidermonkey (60) will lose jit USE flag and
      have that unconditional on arches where it's supported, so these
      conditionals will then result in wrong code paths being taken. Therefore
      just simplify it to the basics and hope it works and rely on any incoming
      bugs about it to modernize this.
    
    Closes: https://bugs.gentoo.org/655426
    Closes: https://bugs.gentoo.org/553966
    Signed-off-by: Mart Raudsepp <leio@gentoo.org>
    Package-Manager: Portage-2.3.49, Repoman-2.3.11

 gnome-base/gnome-shell/Manifest                    |   2 +
 .../files/3.26-optional-bluetooth.patch            |  73 ++++++++
 .../gnome-shell/gnome-shell-3.26.2-r4.ebuild       | 186 +++++++++++++++++++++
 gnome-base/gnome-shell/metadata.xml                |   3 +
 4 files changed, 264 insertions(+)