Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 655306 - app-emulation/virtualbox-modules should respect the CC environment variable
Summary: app-emulation/virtualbox-modules should respect the CC environment variable
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Lars Wendler (Polynomial-C) (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-09 02:11 UTC by whatever
Modified: 2018-05-10 18:58 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description whatever 2018-05-09 02:11:42 UTC 
None of ebuilds for app-emulation/virtualbox-modules respect the CC environment variable, so the kernel module gets compiled with the default gcc.


virtualbox-modules-5.1.36.ebuild
37:	BUILD_PARAMS="KERN_DIR=${KV_DIR} O=${KV_OUT_DIR} V=1 KBUILD_VERBOSE=1"

virtualbox-modules-5.2.10.ebuild
37:	BUILD_PARAMS="KERN_DIR=${KV_DIR} KERN_VER=${KV_FULL} O=${KV_OUT_DIR} V=1 KBUILD_VERBOSE=1"

virtualbox-modules-5.1.32.ebuild
37:	BUILD_PARAMS="KERN_DIR=${KV_DIR} O=${KV_OUT_DIR} V=1 KBUILD_VERBOSE=1"

virtualbox-modules-5.1.34.ebuild
37:	BUILD_PARAMS="KERN_DIR=${KV_DIR} O=${KV_OUT_DIR} V=1 KBUILD_VERBOSE=1"

virtualbox-modules-5.2.8.ebuild
37:	BUILD_PARAMS="KERN_DIR=${KV_DIR} KERN_VER=${KV_FULL} O=${KV_OUT_DIR} V=1 KBUILD_VERBOSE=1"


Looking at x11-drivers/nvidia-drivers (where overriding CC works correctly), the BUILD_PARAMS variable in app-emulation/virtualbox-modules should include CC=$(tc-getBUILD_CC) for the CC variable to get propagated to the eclass.
Comment 1 Georgy Yakovlev archtester gentoo-dev 2018-05-09 18:51:12 UTC 
Can confirm.

Lars, I can work on this bug if you are ok with that.

Not sure if proposed solution is correct, I'll take a look.
Comment 2 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2018-05-09 20:09:49 UTC 
(In reply to Georgy Yakovlev from comment #1)
> Can confirm.
> 
> Lars, I can work on this bug if you are ok with that.

Of course I'm okay with it.
Comment 3 Larry the Git Cow gentoo-dev 2018-05-10 18:58:31 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d10d776abcf9510001f2127526fe9090da2a6c97

commit d10d776abcf9510001f2127526fe9090da2a6c97
Author:     Georgy Yakovlev <ya@sysdump.net>
AuthorDate: 2018-05-10 01:11:27 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2018-05-10 18:58:14 +0000

    app-emulation/virtualbox-modules: respect CC variable.
    
    Closes: https://bugs.gentoo.org/655306
    Package-Manager: Portage-2.3.36, Repoman-2.3.9
    Closes: https://github.com/gentoo/gentoo/pull/8330

 app-emulation/virtualbox-modules/virtualbox-modules-5.1.32.ebuild | 2 +-
 app-emulation/virtualbox-modules/virtualbox-modules-5.1.34.ebuild | 2 +-
 app-emulation/virtualbox-modules/virtualbox-modules-5.1.36.ebuild | 2 +-
 app-emulation/virtualbox-modules/virtualbox-modules-5.2.10.ebuild | 2 +-
 app-emulation/virtualbox-modules/virtualbox-modules-5.2.8.ebuild  | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)