Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 655256 - rpm.eclass: does not inherit estack and uses epatch
Summary: rpm.eclass: does not inherit estack and uses epatch
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords: PATCH, PullRequest
: 655260 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-05-08 06:42 UTC by Martin Väth
Modified: 2021-06-26 17:11 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
bug-655256-rpm-eclass.patch (bug-655256-rpm-eclass.patch,1019 bytes, patch)
2019-06-18 18:19 UTC, Brian Evans (RETIRED)
Details | Diff
bug-655256-rpm-eclass.patch (bug-655256-rpm-eclass.patch,970 bytes, patch)
2019-06-18 18:27 UTC, Brian Evans (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Väth 2018-05-08 06:42:30 UTC
rpm.eclass inherits eutils instead of estack for eshopts_push and shopts_pop.
This breaks in EAPI 7.

Also in rpm_spec_epatch the command "epatch" is used:
Since epatch is banned in EAPI 7, either this function needs to be banned in EAPI 7, too, or eapply has to be used instead for EAPI 7.

(For earlier EAPIs perhaps also epatch instead of eutils might be inherited, but OTOH this might break some ebuilds which expect that rpm inherits eutils.)
Comment 1 Brian Evans (RETIRED) gentoo-dev 2019-06-18 18:19:31 UTC
Created attachment 580088 [details, diff]
bug-655256-rpm-eclass.patch

Patch to work with latest EAPIs.  The patching function does not work correctly as I've tested it with a local gdb ebuild (the sole consumer in ::gentoo).  For this reason, I have excluded it.
Comment 2 Brian Evans (RETIRED) gentoo-dev 2019-06-18 18:27:07 UTC
Created attachment 580090 [details, diff]
bug-655256-rpm-eclass.patch

Previous patch should not have added that die.  Fixed.
Comment 3 Brian Evans (RETIRED) gentoo-dev 2019-06-23 11:54:01 UTC
*** Bug 655260 has been marked as a duplicate of this bug. ***
Comment 4 Larry the Git Cow gentoo-dev 2021-06-26 17:11:12 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3b4d86d292e43516a6244bb6b7897ac3a28da180

commit 3b4d86d292e43516a6244bb6b7897ac3a28da180
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2021-06-23 18:36:57 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2021-06-26 17:05:57 +0000

    rpm.eclass: Support EAPI 8, some cleanup
    
    Closes: https://bugs.gentoo.org/655256
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 eclass/rpm.eclass | 33 ++++++++++++++++++++-------------
 1 file changed, 20 insertions(+), 13 deletions(-)