Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 655244 - fcaps.eclass expects trailing slash for ${ED} ${EROOT} (EAPI 7)
Summary: fcaps.eclass expects trailing slash for ${ED} ${EROOT} (EAPI 7)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-08 05:46 UTC by Martin Väth
Modified: 2021-02-18 20:10 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Väth 2018-05-08 05:46:23 UTC
The line

[[ ${file} != /* ]] && file="${root}${file}"

expects that ${root} has a trailing slash, but ${root} is one of ${ED} or ${EROOT} (or ${D} or ${ROOT} as a fallback).
Hence, fcaps breaks with EAPI 7 where these variables lack a trailing slash.
A possible solution is to replace the line by

[[ ${file} != /* ]] && file="${root%/}/${file}"
Comment 1 Larry the Git Cow gentoo-dev 2018-05-08 14:40:04 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=06ac51cf5bdb3220d427819cdfafdab231e4a4f8

commit 06ac51cf5bdb3220d427819cdfafdab231e4a4f8
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2018-05-08 14:38:31 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2018-05-08 14:38:31 +0000

    fcaps.eclass: don't assume D and ROOT end with a slash
    
    Closes: https://bugs.gentoo.org/655244

 eclass/fcaps.eclass | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)