Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 655224 - x11-apps/intel-gpu-tools-1.22 version bump
Summary: x11-apps/intel-gpu-tools-1.22 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-07 21:06 UTC by Casey Bowman
Modified: 2018-06-13 22:16 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Casey Bowman 2018-05-07 21:06:02 UTC
A new version of x11-apps/intel-gpu-tools has been released:
https://cgit.freedesktop.org/xorg/app/intel-gpu-tools/plain/NEWS

I'm currently working on getting a patch ready for a GitHub pull request.

Some changes from 1.20 to 1.22 that will be reflected in the ebuild update:
1) Libudev has been made a mandatory dependency.
2) Libunwind has been made a mandatory dependency.
3) intel-gpu-tools is no longer released pre-configured.
4) Releases since 1.21 on https://www.x.org/releases/individual/app/ seem to use gzip tarballs instead of bzip2 tarballs (I'm looking into whether or not this will become the norm for future releases). If this does become the norm, we might need to add a logic change to how the xorg-2 eclass looks for tarballs.
5) I'm including a patch for KBL and CNL PCI IDs since they won't be available until the 1.23 release.
Comment 1 Matt Turner gentoo-dev 2018-05-08 05:26:33 UTC
(In reply to Casey Bowman from comment #0)
> A new version of x11-apps/intel-gpu-tools has been released:
> https://cgit.freedesktop.org/xorg/app/intel-gpu-tools/plain/NEWS
> 
> I'm currently working on getting a patch ready for a GitHub pull request.
> 
> Some changes from 1.20 to 1.22 that will be reflected in the ebuild update:
> 1) Libudev has been made a mandatory dependency.
> 2) Libunwind has been made a mandatory dependency.
> 3) intel-gpu-tools is no longer released pre-configured.
> 4) Releases since 1.21 on https://www.x.org/releases/individual/app/ seem to
> use gzip tarballs instead of bzip2 tarballs (I'm looking into whether or not
> this will become the norm for future releases). If this does become the
> norm, we might need to add a logic change to how the xorg-2 eclass looks for
> tarballs.
> 5) I'm including a patch for KBL and CNL PCI IDs since they won't be
> available until the 1.23 release.

Thanks. That all sounds great. (Hi fellow Intel co-worker!)
Comment 2 Casey Bowman 2018-05-08 22:56:56 UTC
(Hi Matt!)

I spoke to Petri (one of the current IGT maintainers) and received some answers on points 3) and 4) that I made in my last post.

3) Their new build process no longer uses autotools (now uses Meson), which, as a side effect, results in the non pre-configured releases.

To remedy this, I plan on using XORG_EAUTORECONF="yes" in the update to explicitly call Autotools to configure the source.


4) Another side effect is that the release tarball format has now changed to .tar.xz.

For this, we'll need to change the logic in xorg-2.eclass to support both .tar.xz and .tar.bz2 formats.

I'll be out of office from 05/09/2018 (tomorrow) through 05/16/2018, so if a patch isn't uploaded today, most likely it'll arrive next Thursday.
Comment 3 Matt Turner gentoo-dev 2018-05-09 21:11:52 UTC
It's probably worth considering switching to Meson. I expect at some point autotools support will be removed. I doubt switching the ebuild to use Meson will be a significant amount of work.
Comment 4 Casey Bowman 2018-05-17 16:56:21 UTC
(In reply to Matt Turner from comment #3)
> It's probably worth considering switching to Meson. I expect at some point
> autotools support will be removed. I doubt switching the ebuild to use Meson
> will be a significant amount of work.

Sounds reasonable, I'll look into it.
Comment 5 Matt Turner gentoo-dev 2018-05-31 17:58:14 UTC
(In reply to Casey Bowman from comment #4)
> (In reply to Matt Turner from comment #3)
> > It's probably worth considering switching to Meson. I expect at some point
> > autotools support will be removed. I doubt switching the ebuild to use Meson
> > will be a significant amount of work.
> 
> Sounds reasonable, I'll look into it.

Let me know if you need any help. You might want to idle in #gentoo-desktop on Freenode -- various people there can help.
Comment 6 Casey Bowman 2018-05-31 22:03:14 UTC
(In reply to Matt Turner from comment #5)
> (In reply to Casey Bowman from comment #4)
> > (In reply to Matt Turner from comment #3)
> > > It's probably worth considering switching to Meson. I expect at some point
> > > autotools support will be removed. I doubt switching the ebuild to use Meson
> > > will be a significant amount of work.
> > 
> > Sounds reasonable, I'll look into it.
> 
> Let me know if you need any help. You might want to idle in #gentoo-desktop
> on Freenode -- various people there can help.

Apologies on going silent for a while, other tasks required my attention over the past week an a half or so, but I've got a working ebuild ready in Chromium (https://chromium-review.googlesource.com/c/chromiumos/overlays/portage-stable/+/1080449), but I'm working on testing the Gentoo version in a VM I created, for which I'm still resolving some environmental package dependencies (My day-to-day development system is Ubuntu). It'll be a nice spot check to ensure that intel-gpu-tools compiles in a gentoo environment.

Overall, making the switch to the meson build structure was pretty simple, but it builds the test binaries by default, meaning that if we wanted to change some build flags to prevent that, we'd need to change the meson.build and meson_config.txt files in the intel-gpu-tools source through a patch or in the ebuild. If we wanted to do this, I'd just recommend submitting

The patch should be out shortly (hopefully by EOD).
Comment 7 Casey Bowman 2018-05-31 22:21:10 UTC
> in the ebuild. If we wanted to do this, I'd just recommend submitting
(I cut myself off)

I'd recommend submitting a patch to intel-gpu-tools and epatching that change until a new version of intel-gpu-tools is released that includes the change.
Comment 8 Casey Bowman 2018-06-01 01:06:05 UTC
I've written the intel-gpu-tools-1.22.ebuild and compiled it without issues on my Gentoo VM. However, since this is my first time submitting a Gentoo patch, I want to be sure to follow the steps given in the workflow wiki. Since it's pretty late at the time of this writing, I will get this submitted on Monday, 06/03 (our team is out Friday).
Comment 9 Casey Bowman 2018-06-04 22:41:39 UTC
Created pull request at https://github.com/gentoo/gentoo/pull/8729.

Matt, are there any groups or emails I should add to the pull request?
Comment 10 Matt Turner gentoo-dev 2018-06-05 02:48:54 UTC
Nope, there's a bot that automatically assigns it :)

It would be good to put "Closes: https://bugs.gentoo.org/655224" in the commit though. I'll automatically resolve this bug when the commit is accepted.
Comment 11 Larry the Git Cow gentoo-dev 2018-06-13 22:16:40 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b2204cc6d0f633f0c527aea340c3b4b41074f035

commit b2204cc6d0f633f0c527aea340c3b4b41074f035
Author:     Casey Bowman <casey.g.bowman@intel.com>
AuthorDate: 2018-06-01 00:48:10 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2018-06-13 22:15:47 +0000

    x11-apps/intel-gpu-tools: Version bump to 1.22
    
    This updates intel-gpu-tools to version 1.22, which will use autotools
    because the meson build options are essentially nonexistent, compared to
    the autotools configuration scripts.
    
    This change also adds a live version that uses meson instead of
    autotools.
    
    A patch was included to add KBL and ICL GPU PCI IDs.
    
    Closes: https://bugs.gentoo.org/655224
    Closes: https://github.com/gentoo/gentoo/pull/8729
    Signed-off-by: Casey Bowman <casey.g.bowman@intel.com>

 x11-apps/intel-gpu-tools/Manifest                  |  1 +
 .../intel-gpu-tools-1.22-KBL-ICL-PCI-IDs.patch     | 53 +++++++++++++
 .../intel-gpu-tools/intel-gpu-tools-1.22.ebuild    | 90 ++++++++++++++++++++++
 x11-apps/intel-gpu-tools/metadata.xml              |  1 +
 4 files changed, 145 insertions(+)